From: Tomi Ollila <tomi.ollila@iki.fi>
To: Ben Gamari <bgamari.foss@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 3/3] compact: Provide user with more error feedback
Date: Sun, 20 Oct 2013 21:13:16 +0300 [thread overview]
Message-ID: <m2d2mz7qv7.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1381799585-16274-4-git-send-email-bgamari.foss@gmail.com>
On Tue, Oct 15 2013, Ben Gamari <bgamari.foss@gmail.com> wrote:
> Provide instructions on what to do when we couldn't move the compacted
> database into place.
>
> Signed-off-by: Ben Gamari <bgamari.foss@gmail.com>
> ---
> lib/database.cc | 18 +++++++++++++++++-
> 1 file changed, 17 insertions(+), 1 deletion(-)
>
> diff --git a/lib/database.cc b/lib/database.cc
> index 57c2292..6f9fed1 100644
> --- a/lib/database.cc
> +++ b/lib/database.cc
> @@ -938,7 +938,23 @@ notmuch_database_compact (const char* path,
> }
>
> if (rename(compact_xapian_path, xapian_path)) {
> - fprintf (stderr, "Error moving compacted database\n");
> + fprintf (stderr, "Error moving compacted database into place: %s\n", strerror(errno));
> + fprintf (stderr, "\n");
> + fprintf (stderr, "Encountered error %s while moving the compacted database,\n",
> + strerror(errno));
At this point 'errno' may have changed, so the above error string might not
be the same. Maybe removing the '%s ' part altogether as inserting the part
looks a bit strange...
> + fprintf (stderr, "\n");
> + fprintf (stderr, " %s\n", compact_xapian_path);
> + fprintf (stderr, "\n");
> + fprintf (stderr, "to\n");
> + fprintf (stderr, "\n");
> + fprintf (stderr, " %s\n", xapian_path);
> + fprintf (stderr, "\n");
> + fprintf (stderr, "Please identify the reason for this and move the compacted database into place manually.\n");
> + if (backup_path != NULL) {
> + fprintf (stderr, "Otherwise, you can revert to the backup database located at,\n");
the commas (,) here and a few lines above looks a bit strange to me.
> + fprintf (stderr, "\n");
> + fprintf (stderr, " %s\n", backup_path);
Maybe saying something how to do this revert would be enlightening to the
user... (i.e. mentioning that backup_path needs to be moved as xapian_path).
> + }
> ret = NOTMUCH_STATUS_FILE_ERROR;
> goto DONE;
> }
> --
Tomi
next prev parent reply other threads:[~2013-10-20 18:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-15 1:13 [PATCH] Compact tests and error handling Ben Gamari
2013-10-15 1:13 ` [PATCH 1/3] test: Add compact test Ben Gamari
2013-10-20 12:18 ` David Bremner
2013-10-15 1:13 ` [PATCH 2/3] compact: Give user more feedback on failure renaming Ben Gamari
2013-10-15 1:13 ` [PATCH 3/3] compact: Provide user with more error feedback Ben Gamari
2013-10-20 18:13 ` Tomi Ollila [this message]
2013-10-26 12:26 ` [PATCH] Compact tests and error handling David Bremner
2013-10-27 20:29 ` Ben Gamari
-- strict thread matches above, loose matches on Subject: below --
2013-10-27 20:30 [PATCH 1/3] test: Add compact test Ben Gamari
2013-10-27 20:30 ` [PATCH 3/3] compact: Provide user with more error feedback Ben Gamari
2013-10-27 21:48 ` Tomi Ollila
2013-10-28 22:12 ` Ben Gamari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d2mz7qv7.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bgamari.foss@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).