From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: out of tree build fixes
Date: Thu, 20 Mar 2014 12:29:27 +0200 [thread overview]
Message-ID: <m2d2hhduyg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1395276484-22363-1-git-send-email-david@tethera.net>
On Thu, Mar 20 2014, David Bremner <david@tethera.net> wrote:
> Apparently we've neglected the out of tree builds even more than
> usual. I originally thought this is what was causing the test failures
> on buildbot. I'm less sure now, but I think these fixes don't hurt
> anything, and they do unbreak out of tree builds for me.
>
> There is certainly still work to be done with our out of tree builds.
> For those of you just joining the party, that doesn't mean we want to
> switch to your favourite build system. Or even to Autotools.
>
> An earlier draft of this series (discussed on IRC) defined a builddir
> variable, but eventually I realized the current directory of make is
> always builddir. So at least for now that doesn't seem to be needed.
LGTM. Too bad we cannot expand $(dir) in recipes (or I don't know how),
and using other variables don't bring any benefit (naming would contain
the 'doc' part and we even cannot check whether the variable is defined
or not...).
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-03-20 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 0:48 out of tree build fixes David Bremner
2014-03-20 0:48 ` [PATCH 1/3] build: compute subdirectories from the presence of Makefile.local David Bremner
2014-03-25 2:14 ` David Bremner
2014-03-25 11:40 ` [PATCH] build: move canonical list of subdirectories to configure script David Bremner
2014-03-25 12:31 ` Tomi Ollila
2014-03-25 12:59 ` Jani Nikula
2014-03-20 0:48 ` [PATCH 2/3] doc: fix out-of-tree build David Bremner
2014-03-20 0:48 ` [PATCH 3/3] test: use $(srcdir) instead of . as include path David Bremner
2014-03-20 10:29 ` Tomi Ollila [this message]
2014-03-22 17:27 ` out of tree build fixes Jani Nikula
2014-03-25 22:48 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d2hhduyg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).