From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Michal Sojka <sojkam1@fel.cvut.cz>,
notmuch@notmuchmail.org
Subject: Re: [PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering
Date: Thu, 01 Jan 2015 14:03:47 +0200 [thread overview]
Message-ID: <m2d26yhfmk.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87vbkrfs66.fsf@maritornes.cs.unb.ca>
On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
>
>> This option allows to configure the criterion for duplicate address
>> filtering. Without this option, all unique combinations of name and
>> address parts are printed. This option allows to filter the output
>> more, for example to only contain unique address parts.
>
> I had the feeling there was some "controversy" about the UI here, but
> following back the 3 versions of the series I didn't see it. Does that
> mean we just need to sanity check the code, or are there outstanding
> bikes to shed?
I have intentionally been guiet on this during the review process of the
other patches to not slow down the acceptance of the others. I have not
got enough time to look the implemenentation or think this last patch
further -- from the user interface point of view I recall seeing there
both useless features (but which might be warranted by implementation
simplicity) and missing features (but which might not be there due to
difficulty in implementation). Also, I am not sure whether the --filter-by
is good option (and options descriptive...)...
...I'll look into this soon....
>
> d
Tomi
next prev parent reply other threads:[~2015-01-01 12:04 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 0:25 [PATCH v3 00/10] "notmuch address" command Michal Sojka
2014-11-05 0:25 ` [PATCH v3 01/10] cli: search: Rename options to context Michal Sojka
2014-11-05 0:25 ` [PATCH v3 02/10] cli: search: Move more variables into search_context_t Michal Sojka
2014-11-05 0:25 ` [PATCH v3 03/10] cli: search: Convert ctx. to ctx-> Michal Sojka
2014-11-05 0:25 ` [PATCH v3 04/10] cli: search: Split notmuch_search_command to smaller functions Michal Sojka
2014-11-05 0:25 ` [PATCH v3 05/10] cli: add support for hierarchical command line option arrays Michal Sojka
2014-11-05 0:25 ` [PATCH v3 06/10] cli: Introduce "notmuch address" command Michal Sojka
2014-11-05 20:49 ` Tomi Ollila
2014-11-05 0:25 ` [PATCH v3 07/10] cli: search: Convert --output to keyword argument Michal Sojka
2014-11-05 0:25 ` [PATCH v3 08/10] cli: address: Do not output duplicate addresses Michal Sojka
2014-11-05 0:25 ` [PATCH v3 09/10] cli: address: Add --output=count Michal Sojka
2014-11-05 20:57 ` Tomi Ollila
2014-11-05 23:00 ` David Bremner
2014-11-05 0:25 ` [PATCH v3 10/10] cli: address: Add --filter-by option to configure address filtering Michal Sojka
2014-12-31 21:03 ` David Bremner
2015-01-01 12:03 ` Tomi Ollila [this message]
2015-01-09 13:22 ` Michal Sojka
2015-01-09 14:13 ` Tomi Ollila
2015-01-09 15:29 ` Michal Sojka
2015-01-09 16:31 ` Michal Sojka
2015-10-24 0:55 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d26yhfmk.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
--cc=sojkam1@fel.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).