From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>,
Andrew Burgess <andrew.burgess@embecosm.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] configure: drop use of "pkg-config emacs"
Date: Sun, 06 Dec 2015 20:10:15 +0200 [thread overview]
Message-ID: <m2d1ujjvnc.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1449418220-17790-1-git-send-email-david@tethera.net>
On Sun, Dec 06 2015, David Bremner <david@tethera.net> wrote:
> This does not play well with --prefix. As Tomi notes in
> id:m2k2p2rwth.fsf@guru.guru-group.fi, people still have the option of e.g.
>
> % ./configure ---emacslispdir=`pkg-config emacs --variable sitepkglispdir`
> ---
> oops, I missed a second use of pkg-config emacs
LGTM. Patch applies. I cannot see how this could fail...
Tomi
>
> configure | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/configure b/configure
> index 440d678..abd28da 100755
> --- a/configure
> +++ b/configure
> @@ -472,19 +472,11 @@ else
> fi
>
> if [ -z "${EMACSLISPDIR}" ]; then
> - if pkg-config --exists emacs; then
> - EMACSLISPDIR=$(pkg-config emacs --variable sitepkglispdir)
> - else
> - EMACSLISPDIR='$(prefix)/share/emacs/site-lisp'
> - fi
> + EMACSLISPDIR='$(prefix)/share/emacs/site-lisp'
> fi
>
> if [ -z "${EMACSETCDIR}" ]; then
> - if pkg-config --exists emacs; then
> - EMACSETCDIR=$(pkg-config emacs --variable sitepkglispdir)
> - else
> - EMACSETCDIR='$(prefix)/share/emacs/site-lisp'
> - fi
> + EMACSETCDIR='$(prefix)/share/emacs/site-lisp'
> fi
>
> printf "Checking if emacs is available... "
> --
> 2.6.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2015-12-06 18:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-25 17:32 [PATCH] configure: Use $prefix for emacs, even when pkg-config is available Andrew Burgess
2015-11-26 18:45 ` Tomi Ollila
2015-11-28 13:07 ` David Bremner
2015-11-28 15:02 ` Tomi Ollila
2015-12-06 16:04 ` [PATCH] configure: drop use of "pkg-config emacs" David Bremner
2015-12-06 16:10 ` David Bremner
2015-12-06 18:10 ` Tomi Ollila [this message]
2015-12-10 1:07 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d1ujjvnc.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=andrew.burgess@embecosm.com \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).