From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 5C2626DE1075
 for <notmuch@notmuchmail.org>; Wed,  3 Apr 2019 13:10:59 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.451
X-Spam-Level: 
X-Spam-Status: No, score=0.451 tagged_above=-999 required=5 tests=[AWL=-0.201, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id hoT2cx16ppuc for <notmuch@notmuchmail.org>;
 Wed,  3 Apr 2019 13:10:58 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 9C0A46DE0ED6
 for <notmuch@notmuchmail.org>; Wed,  3 Apr 2019 13:10:58 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 9FA1710019F;
 Wed,  3 Apr 2019 23:10:56 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: =?utf-8?Q?=C3=96rjan?= Ekeberg <ekeberg@kth.se>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/2] Updating tags when replying or forwarding via a
 buffer-local variable
In-Reply-To: <87k1gcvkha.fsf@swing.csc.kth.se>
References: <20190330214821.4150-1-ekeberg@kth.se>
 <m2d0m5l8qn.fsf@guru.guru-group.fi> <87k1gcvkha.fsf@swing.csc.kth.se>
User-Agent: Notmuch/0.28.3+42~g7b16377 (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 03 Apr 2019 23:10:56 +0300
Message-ID: <m2d0m2onn3.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 03 Apr 2019 20:10:59 -0000

On Tue, Apr 02 2019, =C3=96rjan Ekeberg wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>> two things
>>
>> - I wonder whether we could drop (defun notmuch-message-mark-replied ().=
..)
>>   - why is it needed for backward compatibility ?
>
> Yes, it would be cleaner to simply remove it.  My thought was that there
> is a slight risk that someone is explicitly using or manipulating this
> function in some personal code.  This is probably very unlikely, so I am
> more than happy to drop it.

I think dropping is safe.

>> - A test of a few would be nice to see how this behaves -- and we can see
>>   that this still works e.g. on emacs 24...
>
> Indeed.  I did consider this, but since I am not at all familiar with
> how to write such tests, I did not proceed with this.

No-one is, but with little investigation, and then (ab)using some of the
current emacs tests as base for a new test should be doable.

>
> /=C3=96rjan

Tomi