From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id cH1wKfaDKl8EKAAA0tVLHw (envelope-from ) for ; Wed, 05 Aug 2020 10:03:34 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id QKBFJfaDKl8SdgAAB5/wlQ (envelope-from ) for ; Wed, 05 Aug 2020 10:03:34 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3816B940981 for ; Wed, 5 Aug 2020 10:03:33 +0000 (UTC) Received: from [144.217.243.247] (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1577A29A96; Wed, 5 Aug 2020 06:03:27 -0400 (EDT) Received: from mail-wr1-x441.google.com (mail-wr1-x441.google.com [IPv6:2a00:1450:4864:20::441]) by mail.notmuchmail.org (Postfix) with ESMTPS id 3E4B21FF91 for ; Wed, 5 Aug 2020 06:03:25 -0400 (EDT) Received: by mail-wr1-x441.google.com with SMTP id y3so40098608wrl.4 for ; Wed, 05 Aug 2020 03:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dme-org.20150623.gappssmtp.com; s=20150623; h=to:subject:in-reply-to:references:from:date:message-id:mime-version; bh=pMY/WQ1NpMGP7YaDq3iV7U9eGpfpqZ3k+QhSCAnITkY=; b=mOF3w4dP92Jpmz4WEyCC05jLfriCqSPt4Zu/HoxWHn37ebFha4SxB8PAThFzWVPV3B E6dssfAM7auZZt8TOGQX7CpRonJkXn/WrEJnch/qYBq9PrSE5ia14MXOfLW6QVsGOFLp WE628SbPIOfYC8ccqy/0h9tyOkARV6N/0qX6CEaAtWtx296nzaTZk3vu2gRRwiaO/2YR GcPfRcCbuU6VtctM0s0yJZM0qnawAzISgbieprzhQz5CMPHIvzHsyOCYJ64yWZUbBIWo d7zwr9ZswFDDQ5MyOGWNMvpxboXrPR+ZHMW1rVquEkii8TG4rIAUjRSerUGkSQvvAEca iL2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:subject:in-reply-to:references:from:date :message-id:mime-version; bh=pMY/WQ1NpMGP7YaDq3iV7U9eGpfpqZ3k+QhSCAnITkY=; b=pQ5Iy37uq214+0LWHQGBtgInSGLTBCYQn5/JJdUbwCHLhM3U5XslRRA+uzX2gMIYeq 7uxeXLzExTMoje8h2wnc/8MxFr2/FPG6J6wcAKWullPwo97tLh7zDs1UqwPBeUomWVFz jlchJjRzptlQg6koAgsGRdIle1vOl2TuKM7t9Fh8QmoOZksbOtTH+tTdHlFoEUEqZ8k7 IlXNJER36ukhDrD+533yvcsrhXy0yfE0RhGFK8HSdxZRVRTHEwXpiAQoZ8OjoLRYInDt bNZXDDlVlxC2YHPzA1Vq2g944U1UpZBj8PeW4RwL03KRkGaF4tHN8UjMiEPo/EX9DnVg PAZw== X-Gm-Message-State: AOAM53344jv7HXc2aW8RI2xDJn9mXMqS5pki6WxkVSgYGR+MMB/27cJ+ u86RzI8Gy28i/cUWH0Y7jsIasbsI6+V9dA== X-Google-Smtp-Source: ABdhPJz36+7Iapbo/Nhs6GpVN1dw4r0rogklEB95a78lCLAa8X3n6Nhqxmy7OTAZLMOJ+WbtjUerQA== X-Received: by 2002:adf:aad8:: with SMTP id i24mr2066528wrc.336.1596621803308; Wed, 05 Aug 2020 03:03:23 -0700 (PDT) Received: from disaster-area.hh.sledj.net (8.a.e.d.0.0.0.0.0.0.0.0.4.6.0.0.0.4.1.7.1.7.b.b.0.b.8.0.1.0.0.2.ip6.arpa. [2001:8b0:bb71:7140:64::dea8]) by smtp.gmail.com with ESMTPSA id q4sm2106704wme.31.2020.08.05.03.03.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2020 03:03:04 -0700 (PDT) Received: from localhost (disaster-area.hh.sledj.net [local]) by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 878c731d; Wed, 5 Aug 2020 10:03:00 +0000 (UTC) To: Teemu Likonen , notmuch@notmuchmail.org Subject: Re: [PATCH v3] Emacs: Force left-to-right display for message headers In-Reply-To: <877dudfn2h.fsf@iki.fi> References: <87y2muvc5j.fsf@iki.fi> <20200804180225.12888-1-tlikonen@iki.fi> <877dudfn2h.fsf@iki.fi> X-HGTTG: heart-of-gold From: David Edmondson Date: Wed, 05 Aug 2020 11:03:00 +0100 Message-ID: MIME-Version: 1.0 Message-ID-Hash: 326QPNO3D4UAU4ANNDJZKYK5W54N3I25 X-Message-ID-Hash: 326QPNO3D4UAU4ANNDJZKYK5W54N3I25 X-MailFrom: dme@dme.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=dme-org.20150623.gappssmtp.com header.s=20150623 header.b=mOF3w4dP; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 0.03 X-TUID: /ghb/6BbxOQx On Wednesday, 2020-08-05 at 12:40:06 +03, Teemu Likonen wrote: > * 2020-08-05 09:45:23+01, David Edmondson wrote: > >> I've no idea if this is the appropriate approach to addressing this, but >> the resulting behaviour is obviously an improvement over what happens >> now. > > I think there are two options: > > 1. Add a string like "From: " in the beginning of notmuch-show header > paragraph so that the paragraph always starts with left-to-right > characters (those latin letters "From"). > > 2. Add invisible characters that force left-to-right text for the > paragraph. Character U+200E LEFT-TO-RIGHT MARK is meant for > controlling exactly that. > > My patch implements the option 2 and... It seems fine. Reviewed-by: David Edmondson >> It would make sense to add some commentary to the code as well as the >> commit message explaining the reason for inserting the seemingly >> arbitrary character. > > ...it has at least comment > > ; U+200E LEFT-TO-RIGHT MARK > > in the code. I think that explains the purpose quite well. More verbose > explanation could be something like this: > > ;; Add invisible U+200E LEFT-TO-RIGHT MARK character to force the > ;; header paragraph as left-to-right text even if some header's > ;; content is right-to-left. This is much more useful to someone looking at the code (I know that the explanation is in the commit, but when things get moved around a lot, chasing back through commit messages can be time consuming and difficult). dme. -- It's gettin', it's gettin', it's gettin' kinda hectic.