From: David Edmondson <dme@dme.org>
To: Teemu Likonen <tlikonen@iki.fi>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3] Emacs: Force left-to-right display for message headers
Date: Wed, 05 Aug 2020 11:03:00 +0100 [thread overview]
Message-ID: <m2d045beaz.fsf@dme.org> (raw)
In-Reply-To: <877dudfn2h.fsf@iki.fi>
On Wednesday, 2020-08-05 at 12:40:06 +03, Teemu Likonen wrote:
> * 2020-08-05 09:45:23+01, David Edmondson wrote:
>
>> I've no idea if this is the appropriate approach to addressing this, but
>> the resulting behaviour is obviously an improvement over what happens
>> now.
>
> I think there are two options:
>
> 1. Add a string like "From: " in the beginning of notmuch-show header
> paragraph so that the paragraph always starts with left-to-right
> characters (those latin letters "From").
>
> 2. Add invisible characters that force left-to-right text for the
> paragraph. Character U+200E LEFT-TO-RIGHT MARK is meant for
> controlling exactly that.
>
> My patch implements the option 2 and...
It seems fine.
Reviewed-by: David Edmondson <dme@dme.org>
>> It would make sense to add some commentary to the code as well as the
>> commit message explaining the reason for inserting the seemingly
>> arbitrary character.
>
> ...it has at least comment
>
> ; U+200E LEFT-TO-RIGHT MARK
>
> in the code. I think that explains the purpose quite well. More verbose
> explanation could be something like this:
>
> ;; Add invisible U+200E LEFT-TO-RIGHT MARK character to force the
> ;; header paragraph as left-to-right text even if some header's
> ;; content is right-to-left.
This is much more useful to someone looking at the code (I know that the
explanation is in the commit, but when things get moved around a lot,
chasing back through commit messages can be time consuming and
difficult).
dme.
--
It's gettin', it's gettin', it's gettin' kinda hectic.
next prev parent reply other threads:[~2020-08-05 10:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 6:13 Message headers in right-to-left mode in Emacs notmuch-show-mode Teemu Likonen
2020-08-03 7:37 ` Teemu Likonen
2020-08-04 12:16 ` [PATCH v2] Emacs: Force left-to-right display for message headers Teemu Likonen
2020-08-04 18:02 ` [PATCH v3] " Teemu Likonen
2020-08-05 8:45 ` David Edmondson
2020-08-05 9:40 ` Teemu Likonen
2020-08-05 9:50 ` Teemu Likonen
2020-08-05 10:03 ` David Edmondson [this message]
2020-08-05 10:32 ` [PATCH v4] " Teemu Likonen
2020-08-06 12:04 ` David Bremner
2020-08-06 14:50 ` Teemu Likonen
2020-08-06 14:59 ` Teemu Likonen
2020-08-07 4:46 ` [PATCH v5] Emacs: Ensure " Teemu Likonen
2020-08-07 9:23 ` David Edmondson
2020-08-08 19:21 ` David Bremner
2020-08-09 20:12 ` =?utf-8?Q?T=E2=80=AEomi?= Ollila
2020-08-10 8:43 ` David Edmondson
2020-08-10 16:45 ` Teemu Likonen
2020-08-10 18:27 ` Sanitize bidi control chars Teemu Likonen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2d045beaz.fsf@dme.org \
--to=dme@dme.org \
--cc=notmuch@notmuchmail.org \
--cc=tlikonen@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).