From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 0LrxALw+0l8SSAAA0tVLHw (envelope-from ) for ; Thu, 10 Dec 2020 15:29:00 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id iPlUOLs+0l+QcgAA1q6Kng (envelope-from ) for ; Thu, 10 Dec 2020 15:28:59 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34B18940149 for ; Thu, 10 Dec 2020 15:28:59 +0000 (UTC) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id AA97329C4E; Thu, 10 Dec 2020 10:28:49 -0500 (EST) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 966652710D for ; Thu, 10 Dec 2020 10:28:46 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id F3CB71B0036E; Thu, 10 Dec 2020 17:28:33 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1607614114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MWVOkREvJR80QDCdbju9lotCQyvocL3ih4rdDIGnOxE=; b=u/RCqWmF6ngfvh/IrhtXAcJKwbPVqPCZpGIu1I7D4miFcWLHzahGH0fDyLWLTz+uJ95QKY gbwFNS3BanQsS+STF9kOPZz/WdG1rS4b7uqsDIUMVbV7Qmdn39qbOvnmtfAdCgSIGZX8Vf hgGXNLMIiwgsE368ETdFXRBSVBDeP5ivsSwurXwwVUOljCsqASsEqaOBD/WFyHyv36qe1k bax0opTEM9haP4Ak+ViuQVjHSsIYrKPksmuxlRJ2nUpPBe+Pu7pz/v39CDs/4f7D1lGKL5 wF0etNlJC2lE+2AkVYAcqz/fbJqvA5yk9FiOBTv+3qqXdfgaYJXrrNzUuzrRDQ== From: Tomi Ollila To: David Bremner , 976934@bugs.debian.org, notmuch@notmuchmail.org Subject: Re: [PATCH] build/docs: move docstring prereq to file targets In-Reply-To: <20201210020038.2390525-1-david@tethera.net> References: <20201210020038.2390525-1-david@tethera.net> User-Agent: Notmuch/0.31.2+29~gf517255 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1607614114; a=rsa-sha256; cv=none; b=tmYbbqnFDPUZGSOScYldreO9Whzhaf31Cw5UaOh3HshaTDrKBDvec0nvvm3jWYstPKna6t P7tQuJ/0xu+5HFui1z8/jd/Dqt/1NIHt6ZmtuNi7hRMD/e2SvUZBeSbemWoPp/bo4ZzGAw y3rt9G88U2lepbpWMg1Z/CxintIBgzIxpMGu5Py9ekuFf4ARVUMTJRhzWnm0jffmDI/3pv OhmIujMBsJaH1pORFQZfUxVgle1Uu9Jf2IssDTcKDEPM1sBMZyxWDtjsfwA4QASkPTso2O 3qHdZBqjoJ9KjCrpgafzdJbI4G6ZQh43hCOYMmGVT2eUWv7V0qusopaHZMdA3A== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1607614114; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=MWVOkREvJR80QDCdbju9lotCQyvocL3ih4rdDIGnOxE=; b=YhimbQlP5cpFDRX7Ap8dsrSAZ3i3QINliShQoCqRTloW3ksI3urJWBZCoKwLeieGB1k0/T dKUlQDcK9tiBX8r1lNt0pCiS8yZX/eJPUSXngScXsuWFVxeYsII/UOL5Z+uBoCnm29AEpW n2QcoZMJL3Q5mxwTJZs6xEDcIHpzlNP41U4b/cTdEwTtUxcGLrKlB2ELKuICVWRUTvQ/9h ph2FiGwXLPqFbFkurkrD+0d5gE8pGW1pSuJu8p+JqWaKHw6UBOdqoFJaXqquPUf/8KxetG uUNgpMR9Sj36f5x3Krs0zMdwlbn2KFXJ5aBDOGNb5GwvVzhThUrmH4CQ/7IpDA== Message-ID-Hash: SVJK7ARGXQODH5P5MMEJOZICWUIDJSTK X-Message-ID-Hash: SVJK7ARGXQODH5P5MMEJOZICWUIDJSTK X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.74 Authentication-Results: aspmx1.migadu.com; dkim=fail (body hash did not verify) header.d=iki.fi header.s=lahtoruutu header.b=u/RCqWmF; arc=reject (signature check failed: fail, {[1] = sig:iki.fi:reject}); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 34B18940149 X-Spam-Score: 2.74 X-Migadu-Scanner: scn1.migadu.com X-TUID: 5Zsu7ON2nSey On Wed, Dec 09 2020, David Bremner wrote: > Under a sufficiently high level of parallelism [1] there seems to be a > a race condition that allows sphinx-build to start running before the > docstrings are extracted. This change moves the docstring stamp from > the phony targets sphinx-html and sphinx-info to the file targets that > they depend on. I'm not sure why this makes things better, but I am > fairly confident it does not make things worse, and experimentally it > seems to eliminate the race condition. Good enough for me if this helps. I also don't see reason why that would make things better (and probably not things worse), just that I got headache reading that Makefile ;) (and, for example, these particular targets mentioned would not need to be marked .PHONY...) I'd suggest to monitor the behaviour for a while and if things are consistently better then merge -- such a things when we don't know enough experience may be enough (or someone(tm) could try to parse make debug logs ;/) -- or someone(tm) may tell us why that heleps :D Tomi > > [1]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=976934 > --- > doc/Makefile.local | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/Makefile.local b/doc/Makefile.local > index 60bd7184..f476d1da 100644 > --- a/doc/Makefile.local > +++ b/doc/Makefile.local > @@ -43,7 +43,7 @@ INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info) > rm -f $@ && gzip --no-name --stdout $^ > $@ > > ifeq ($(WITH_EMACS),1) > -$(DOCBUILDDIR)/.roff.stamp sphinx-html sphinx-texinfo: docstring.stamp > +$(DOCBUILDDIR)/.roff.stamp $(DOCBUILDDIR)/.html.stamp $(DOCBUILDDIR)/.texi.stamp : docstring.stamp > endif > > sphinx-html: $(DOCBUILDDIR)/.html.stamp > -- > 2.29.2 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org