unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] perf-test: fix for verbose
@ 2021-06-26 20:13 Felipe Contreras
  2021-08-05 12:11 ` David Bremner
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Contreras @ 2021-06-26 20:13 UTC (permalink / raw)
  To: notmuch; +Cc: Felipe Contreras

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
---

I don't know how $verbose is supposed to be set, but when I manually did
it didn't work.

 performance-test/perf-test-lib.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/performance-test/perf-test-lib.sh b/performance-test/perf-test-lib.sh
index e7c502b6..41b1ddfd 100644
--- a/performance-test/perf-test-lib.sh
+++ b/performance-test/perf-test-lib.sh
@@ -212,7 +212,7 @@ time_run ()
 {
     printf "  %-22s" "$1"
     test_count=$(($test_count+1))
-    if test "$verbose" != "t"; then exec 4>test.output 3>&4; fi
+    if test "$verbose" != "t"; then exec 4>test.output 3>&4; else exec 3>&1; fi
     if [[ "$use_perf" = 1 ]]; then
 	command_str="perf record --call-graph=${perf_callgraph} -o ${log_dir}/${test_count}.perf $2"
     else
-- 
2.32.0

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf-test: fix for verbose
  2021-06-26 20:13 [PATCH] perf-test: fix for verbose Felipe Contreras
@ 2021-08-05 12:11 ` David Bremner
  2021-08-09 20:03   ` Tomi Ollila
  0 siblings, 1 reply; 3+ messages in thread
From: David Bremner @ 2021-08-05 12:11 UTC (permalink / raw)
  To: Felipe Contreras, notmuch; +Cc: Felipe Contreras

Felipe Contreras <felipe.contreras@gmail.com> writes:

> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>

applied to master.

shout out to Tomi for the review.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] perf-test: fix for verbose
  2021-08-05 12:11 ` David Bremner
@ 2021-08-09 20:03   ` Tomi Ollila
  0 siblings, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2021-08-09 20:03 UTC (permalink / raw)
  To: David Bremner, Felipe Contreras, notmuch; +Cc: Felipe Contreras

On Thu, Aug 05 2021, David Bremner wrote:

> Felipe Contreras <felipe.contreras@gmail.com> writes:
>
>> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>
> applied to master.
>
> shout out to Tomi for the review.

I guess I was the one who dropped the needs-review...

Tomi

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-08-09 20:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-26 20:13 [PATCH] perf-test: fix for verbose Felipe Contreras
2021-08-05 12:11 ` David Bremner
2021-08-09 20:03   ` Tomi Ollila

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).