unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
	Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH] config: add quoting to fix IFS bug
Date: Sun, 03 Jun 2012 18:07:11 +0300	[thread overview]
Message-ID: <m2bol0juxs.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1338660961-13760-1-git-send-email-jrollins@finestructure.net>

On Sat, Jun 02 2012, Jameson Graef Rollins <jrollins@finestructure.net> wrote:

> Without proper quoting the DEFAULT_IFS was getting set incorrectly,
> which was causing problems with the storage of some variables later in
> the script.  Quoting fixes the problem.

LGTM

Tomi


> ---
> Thanks to Tomi for the inspiration for this fix.  I don't know how I
> missed such a simple solution initially.
>
>  configure |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5602be2..3fad424 100755
> --- a/configure
> +++ b/configure
> @@ -1,7 +1,7 @@
>  #! /bin/sh
>  
>  # Store original IFS value so it can be changed (and restored) in many places.
> -readonly DEFAULT_IFS=$IFS
> +readonly DEFAULT_IFS="$IFS"
>  
>  srcdir=$(dirname "$0")
>  
> -- 
> 1.7.10
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2012-06-03 15:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-02 18:16 [PATCH] config: add quoting to fix IFS bug Jameson Graef Rollins
2012-06-03 15:07 ` Tomi Ollila [this message]
2012-06-03 16:32 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bol0juxs.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).