From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 90104431FB6
	for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 02:14:20 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id WZdtoh3gFw3L for <notmuch@notmuchmail.org>;
	Sat, 20 Oct 2012 02:14:19 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 8DCB6431FAE
	for <notmuch@notmuchmail.org>; Sat, 20 Oct 2012 02:14:19 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 243A81000E5;
	Sat, 20 Oct 2012 12:14:21 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Daniel Bergey <bergey@alum.mit.edu>,
	Notmuch Mail List <notmuch@notmuchmail.org>
Subject: Re: [PATCH] emacs: functions to import sender or recipient into BBDB
In-Reply-To: <87ipa66pne.fsf@betacantrips.com>
References: <87lii62sk2.fsf@wonderlust.lan> <87ipa66pne.fsf@betacantrips.com>
User-Agent: Notmuch/0.14+51~g62cd13b (http://notmuchmail.org) Emacs/24.2.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 20 Oct 2012 12:14:20 +0300
Message-ID: <m2bofxa4k3.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Oct 2012 09:14:20 -0000

On Sat, Oct 20 2012, Ethan Glasser-Camp wrote:

> Daniel Bergey <bergey@alum.mit.edu> writes:
>
>> From a show buffer, bbdb/notmuch-snarf-from imports the sender into
>> bbdb.  bbdb/notmuch-snarf-to attempts to import all recipients.  BBDB
>> displays a buffer with each contact; C-g displays the next contact, or
>> returns to the notmuch-show buffer.
>>
>> This is my first notmuch patch.  Comments very welcome.
>
> Hi!
>
>>  emacs/notmuch-show.el |   28 ++++++++++++++++++++++++++++
>
> I don't think this belongs in notmuch-show. My first inclination is that
> this should go into a new file contrib/notmuch-bbdb.el (assuming there's
> no other notmuch-bbdb integration stuff floating around).
>
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
>> index 6335d45..3bc1da0 100644
>> --- a/emacs/notmuch-show.el
>> +++ b/emacs/notmuch-show.el
>> @@ -1895,6 +1895,34 @@ the user (see `notmuch-show-stash-mlarchive-link-alist')."
>>                      (button-get button :notmuch-filename)
>>                      (button-get button :notmuch-content-type)))))))
>>
>> +;; bbdb interaction functions, awaiting user keybindings
>> +
>> +(defun bbdb/snarf-between-commas ()
>> +  ; What about names written "Surname, First M" <user@server.tld>?
>
> Most comments in emacslisp start with two semicolons.

3 quick comments.

I was thinking notmuch-bbdb.el but contrib/notmuch-bbdb.el could be
good start.

then functions like notmuch-bbdb/snarf-between-commas etc...

and yes, ;; comments -- that also keeps indent-region happy.

Tomi