From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v4 0/3] split async json parser into utility function
Date: Sat, 27 Oct 2012 15:12:29 +0300 [thread overview]
Message-ID: <m2bofoqfki.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1351330452-8348-1-git-send-email-markwalters1009@gmail.com>
On Sat, Oct 27 2012, Mark Walters <markwalters1009@gmail.com> wrote:
> This is version 4 of this patch set (v3 is at
> id:"1351037602-11157-1-git-send-email-markwalters1009@gmail.com"). It
> splits the async json parser into its own function and moves it to
> lib.
>
> This version is very similar to v3 except that it finished by moving
> the utility function to lib rather than leaving it notmuch.el. It also
> improves some of the docstrings to clarify how the function and
> variables work. I have not gone quite as far as suggested by Ethan as
> these variables are purely for internal use and Austin's code is well
> documented.
Changes look good and tests pass.
Tomi
> Best wishes
>
> Mark
>
>
> Mark Walters (3):
> emacs: Split out the incremental json parser into its own function
> emacs: Rename incremental JSON internal variables
> emacs: Move the incremental JSON parser to notmuch-lib.el
>
> emacs/notmuch-lib.el | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
> emacs/notmuch.el | 48 +++---------------------------------
> 2 files changed, 70 insertions(+), 44 deletions(-)
>
> --
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-10-27 12:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-27 9:34 [PATCH v4 0/3] split async json parser into utility function Mark Walters
2012-10-27 9:34 ` [PATCH v4 1/3] emacs: Split out the incremental json parser into its own function Mark Walters
2012-10-27 9:34 ` [PATCH v4 2/3] emacs: Rename incremental JSON internal variables Mark Walters
2012-10-27 9:34 ` [PATCH v4 3/3] emacs: Move the incremental JSON parser to notmuch-lib.el Mark Walters
2012-10-27 12:12 ` Tomi Ollila [this message]
2012-10-28 15:18 ` [PATCH v4 0/3] split async json parser into utility function David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bofoqfki.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).