From: Tomi Ollila <tomi.ollila@iki.fi>
To: david@tethera.net, notmuch@notmuchmail.org
Cc: David Bremner <bremner@debian.org>
Subject: Re: [PATCH] contrib/nmbug: convert to use batch tagging.
Date: Wed, 13 Feb 2013 16:47:27 +0200 [thread overview]
Message-ID: <m2boboe0e8.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1360374019-20988-1-git-send-email-david@tethera.net>
On Sat, Feb 09 2013, david@tethera.net wrote:
> From: David Bremner <bremner@debian.org>
>
> In the case of large changes to the database from git, one of main
> current bottlenecks is the large number of execs of notmuch tag. This
> avoids that by using use the batch tagging facilities as of notmuch
> 0.15.
>
> We use "spawn" directly rather than inventing a "notmuch_pipe", since
> it seems the only place we need to pipe to notmuch so far.
> ---
The code LGTM. Is there any quoting differences between these 2
tagging methods ?
> This is only lightly tested; please make sure you have backups of your
> database.
Do I dare to test -- I'm lazy taking backups (I don't know how to take
one -- and especially how to restore one ;)
> I'm not 100% sure about the indentation. No doubt Tomi will let me
> know if it can be improved.
No doubt...
Tomi
>
> contrib/nmbug/nmbug | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/contrib/nmbug/nmbug b/contrib/nmbug/nmbug
> index f003ef9..c66c526 100755
> --- a/contrib/nmbug/nmbug
> +++ b/contrib/nmbug/nmbug
> @@ -270,17 +270,22 @@ sub do_sync {
> $D_action = '-';
> }
>
> - foreach my $pair (@{$status->{added}}) {
> + my $notmuch = spawn ({}, '|-', qw/notmuch tag --batch/)
> + or die 'notmuch tag --batch';
>
> - notmuch ('tag', $A_action.$TAGPREFIX.$pair->{tag},
> - 'id:'.$pair->{id});
> + foreach my $pair (@{$status->{added}}) {
> + print $notmuch $A_action.$TAGPREFIX.$pair->{tag}, " -- ",
> + 'id:'.$pair->{id};
> }
>
> foreach my $pair (@{$status->{deleted}}) {
> - notmuch ('tag', $D_action.$TAGPREFIX.$pair->{tag},
> - 'id:'.$pair->{id});
> + print $notmuch $D_action.$TAGPREFIX.$pair->{tag},
> + 'id:'.$pair->{id};
> }
>
> + unless (close $notmuch) {
> + die "'notmuch tag --batch' exited with nonzero value\n";
> + }
> }
>
>
> --
> 1.7.10.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2013-02-13 14:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-09 1:40 [PATCH] contrib/nmbug: convert to use batch tagging david
2013-02-13 14:47 ` Tomi Ollila [this message]
2013-02-14 3:02 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2boboe0e8.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=bremner@debian.org \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).