From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 19C45431FBD
	for <notmuch@notmuchmail.org>; Thu,  7 Nov 2013 05:14:16 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id S81In-yVBqkC for <notmuch@notmuchmail.org>;
	Thu,  7 Nov 2013 05:14:07 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id CEF75431FAE
	for <notmuch@notmuchmail.org>; Thu,  7 Nov 2013 05:14:06 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 3CED3100051;
	Thu,  7 Nov 2013 15:14:00 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: add library version check macro
In-Reply-To: <1383764501-18973-1-git-send-email-jani@nikula.org>
References: <1383764501-18973-1-git-send-email-jani@nikula.org>
User-Agent: Notmuch/0.16+119~g219c55f (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 07 Nov 2013 15:13:59 +0200
Message-ID: <m2bo1w9wx4.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 07 Nov 2013 13:14:16 -0000

On Wed, Nov 06 2013, Jani Nikula <jani@nikula.org> wrote:

> There have been some plans for making build incompatible changes to
> the library API. This is inconvenient, but it is much more so without
> a way to easily conditional build against multiple versions of
> notmuch.
>
> The macro has been lifted from glib.

+1

Tomi


> ---
>  lib/notmuch.h | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/lib/notmuch.h b/lib/notmuch.h
> index 9dab555..d109a2c 100644
> --- a/lib/notmuch.h
> +++ b/lib/notmuch.h
> @@ -41,6 +41,30 @@ NOTMUCH_BEGIN_DECLS
>  #define TRUE 1
>  #endif
>  
> +#define NOTMUCH_MAJOR_VERSION	0
> +#define NOTMUCH_MINOR_VERSION	17
> +#define NOTMUCH_MICRO_VERSION	0
> +
> +/*
> + * Check the version of the notmuch library being compiled against.
> + *
> + * Return true if the library being compiled against is of the
> + * specified version or above. For example:
> + *
> + * #if NOTMUCH_CHECK_VERSION(0, 18, 0)
> + *     (code requiring notmuch 0.18 or above)
> + * #endif
> + *
> + * NOTMUCH_CHECK_VERSION has been defined since version 0.17.0; you
> + * can use #if !defined(NOTMUCH_CHECK_VERSION) to check for versions
> + * prior to that.
> + */
> +#define NOTMUCH_CHECK_VERSION (major, minor, micro)			\
> +    (NOTMUCH_MAJOR_VERSION > (major) ||					\
> +     (NOTMUCH_MAJOR_VERSION == (major) && NOTMUCH_MINOR_VERSION > (minor)) || \
> +     (NOTMUCH_MAJOR_VERSION == (major) && NOTMUCH_MINOR_VERSION == (minor) && \
> +      NOTMUCH_MICRO_VERSION >= (micro)))
> +
>  typedef int notmuch_bool_t;
>  
>  /* Status codes used for the return values of most functions.
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch