unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH] lib: add library version check macro
Date: Thu, 07 Nov 2013 15:13:59 +0200	[thread overview]
Message-ID: <m2bo1w9wx4.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1383764501-18973-1-git-send-email-jani@nikula.org>

On Wed, Nov 06 2013, Jani Nikula <jani@nikula.org> wrote:

> There have been some plans for making build incompatible changes to
> the library API. This is inconvenient, but it is much more so without
> a way to easily conditional build against multiple versions of
> notmuch.
>
> The macro has been lifted from glib.

+1

Tomi


> ---
>  lib/notmuch.h | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/lib/notmuch.h b/lib/notmuch.h
> index 9dab555..d109a2c 100644
> --- a/lib/notmuch.h
> +++ b/lib/notmuch.h
> @@ -41,6 +41,30 @@ NOTMUCH_BEGIN_DECLS
>  #define TRUE 1
>  #endif
>  
> +#define NOTMUCH_MAJOR_VERSION	0
> +#define NOTMUCH_MINOR_VERSION	17
> +#define NOTMUCH_MICRO_VERSION	0
> +
> +/*
> + * Check the version of the notmuch library being compiled against.
> + *
> + * Return true if the library being compiled against is of the
> + * specified version or above. For example:
> + *
> + * #if NOTMUCH_CHECK_VERSION(0, 18, 0)
> + *     (code requiring notmuch 0.18 or above)
> + * #endif
> + *
> + * NOTMUCH_CHECK_VERSION has been defined since version 0.17.0; you
> + * can use #if !defined(NOTMUCH_CHECK_VERSION) to check for versions
> + * prior to that.
> + */
> +#define NOTMUCH_CHECK_VERSION (major, minor, micro)			\
> +    (NOTMUCH_MAJOR_VERSION > (major) ||					\
> +     (NOTMUCH_MAJOR_VERSION == (major) && NOTMUCH_MINOR_VERSION > (minor)) || \
> +     (NOTMUCH_MAJOR_VERSION == (major) && NOTMUCH_MINOR_VERSION == (minor) && \
> +      NOTMUCH_MICRO_VERSION >= (micro)))
> +
>  typedef int notmuch_bool_t;
>  
>  /* Status codes used for the return values of most functions.
> -- 
> 1.8.4.rc3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2013-11-07 13:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-11-06 19:01 [PATCH] lib: add library version check macro Jani Nikula
2013-11-06 22:40 ` David Bremner
2013-11-07 13:13 ` Tomi Ollila [this message]
2013-11-07 23:27 ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bo1w9wx4.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=jani@nikula.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).