From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 36DC2431E62
	for <notmuch@notmuchmail.org>; Sun, 12 Jan 2014 01:57:03 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id VIF8jsiuzBY6 for <notmuch@notmuchmail.org>;
	Sun, 12 Jan 2014 01:56:56 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 9B844431FD5
	for <notmuch@notmuchmail.org>; Sun, 12 Jan 2014 01:56:56 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 0542F100086;
	Sun, 12 Jan 2014 11:56:42 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] test: add test for syntax of emacs test library
In-Reply-To: <1389485421-7824-1-git-send-email-david@tethera.net>
References: <1389485421-7824-1-git-send-email-david@tethera.net>
User-Agent: Notmuch/0.17+23~ga575e35 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sun, 12 Jan 2014 11:56:41 +0200
Message-ID: <m2bnzhseue.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sun, 12 Jan 2014 09:57:03 -0000

On Sun, Jan 12 2014, David Bremner <david@tethera.net> wrote:

> If there is a syntax error in the emacs test library, it causes other
> tests to hang or crash without a useful error message.
>
> This test could be eliminated if the error reporting for emacs tests
> was somehow improved.
> ---

This helps developers to deal with some mysteries in the test suite so LGTM.

Tomi


>  test/emacs | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/test/emacs b/test/emacs
> index 863219d..7dc9a8e 100755
> --- a/test/emacs
> +++ b/test/emacs
> @@ -7,6 +7,10 @@ EXPECTED=$TEST_DIRECTORY/emacs.expected-output
>  
>  add_email_corpus
>  
> +# syntax errors in test-lib.el cause mysterious failures
> +test_expect_success 'Syntax of emacs test library' \
> +    "${TEST_EMACS} -Q --batch --load $TEST_DIRECTORY/test-lib.el"
> +
>  test_begin_subtest "Basic notmuch-hello view in emacs"
>  test_emacs '(notmuch-hello)
>  	    (test-output)'
> -- 
> 1.8.5.2