From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] doc: build man pages at build time, not install
Date: Mon, 10 Mar 2014 13:14:50 +0200 [thread overview]
Message-ID: <m2bnxecnkl.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1394449633-14737-1-git-send-email-david@tethera.net>
On Mon, Mar 10 2014, David Bremner <david@tethera.net> wrote:
> This helps avoid build artifacts (namely, nroff and gzipped-nroff man
> pages) owned by root.
> ---
Looks good... on paper :D. +1
Tomi
> Makefile.local | 2 +-
> doc/Makefile.local | 6 ++++--
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Makefile.local b/Makefile.local
> index 5f797ad..cb7b106 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -53,7 +53,7 @@ endif
> FINAL_LIBNOTMUCH_LDFLAGS = $(LDFLAGS) $(AS_NEEDED_LDFLAGS) $(CONFIGURE_LDFLAGS)
>
> .PHONY: all
> -all: notmuch notmuch-shared
> +all: notmuch notmuch-shared build-man
> ifeq ($(MAKECMDGOALS),)
> ifeq ($(shell cat .first-build-message 2>/dev/null),)
> @NOTMUCH_FIRST_BUILD=1 $(MAKE) --no-print-directory all
> diff --git a/doc/Makefile.local b/doc/Makefile.local
> index fd64f70..5be49dc 100644
> --- a/doc/Makefile.local
> +++ b/doc/Makefile.local
> @@ -16,7 +16,7 @@ ALLSPHINXOPTS := -d $(DOCBUILDDIR)/doctrees $(SPHINXOPTS) $(dir)
> .PHONY: sphinx-html sphinx-man sphinx-texinfo sphinx-info
> .PHONY: rst2man
>
> -.PHONY: install-man
> +.PHONY: install-man build-man
>
> %.gz: %
> rm -f $@ && gzip --stdout $^ > $@
> @@ -43,7 +43,9 @@ MAN_GZIP_FILES := $(addsuffix .gz,${MAN_ROFF_FILES})
>
> ${MAN_ROFF_FILES} : sphinx-man
>
> -install-man: ${MAN_GZIP_FILES}
> +build-man: ${MAN_GZIP_FILES}
> +
> +install-man: build-man
> mkdir -p "$(DESTDIR)$(mandir)/man1"
> mkdir -p "$(DESTDIR)$(mandir)/man5"
> mkdir -p "$(DESTDIR)$(mandir)/man7"
> --
> 1.8.5.3
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2014-03-10 11:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 11:07 [PATCH] doc: build man pages at build time, not install David Bremner
2014-03-10 11:14 ` Tomi Ollila [this message]
2014-03-10 17:10 ` Jani Nikula
2014-03-10 22:40 ` Tomi Ollila
2014-03-11 2:18 ` [PATCH 1/3] doc: build man pages at build time; introduce HAVE_SPHINX, HAVE_RST2MAN David Bremner
2014-03-11 2:18 ` [PATCH 2/3] doc: configure detection of sphinx and rst2man David Bremner
2014-03-11 2:18 ` [PATCH 3/3] doc: have prerst2man.py generate roff files all in one directory David Bremner
2014-03-11 2:34 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bnxecnkl.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).