From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jesse Rosenthal <jrosenthal@jhu.edu>,
Mark Walters <markwalters1009@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] Avoid empty thread names if possible.
Date: Wed, 29 Oct 2014 15:32:03 +0200 [thread overview]
Message-ID: <m2bnov57e4.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <87a94f2fe3.fsf@jhu.edu>
On Wed, Oct 29 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:
> By the way, this discussion brings up another problem. I wasn't able to
> write a test for this (to address the below concerns) because the test
> suite for thread-naming supplies some sort of auto-generated subject
> for threads with empty subjects. So we can't test behavior for dealing
> with empty subjects.
>
> Unfortunately, I don't know the history of the test suite, or why this
> auto-subject decisicion was made, so I don't feel comfortable just
> changing the behavior.
Autogeneration of (unique) headers when some header not given...
Shell could distinguish between unset and empty variable, but that would
proably make most users feel PITA to use it... (*)
... probably better altelnative could be some magic word, like 'none' to
make generate_message() set header in question empty (and first just
implement that "feature" to Subject header.
Tomi
(*) personally I'd be totally comfortable with it, though ;D
next prev parent reply other threads:[~2014-10-29 13:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 16:35 [PATCH] Avoid empty thread names if possible Jesse Rosenthal
2014-10-08 15:40 ` Sergei Shilovsky
2014-10-28 17:44 ` Jani Nikula
2014-10-28 21:36 ` Tomi Ollila
2014-10-29 13:21 ` Jesse Rosenthal
2014-10-29 8:34 ` Mark Walters
2014-10-29 13:05 ` Jesse Rosenthal
2014-10-29 13:07 ` Jesse Rosenthal
2014-10-29 13:27 ` Jesse Rosenthal
2014-10-29 13:32 ` Tomi Ollila [this message]
2014-10-29 13:39 ` Jesse Rosenthal
2014-10-29 15:15 ` Mark Walters
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2bnov57e4.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jrosenthal@jhu.edu \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).