From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id A0BC76DE24E8 for ; Wed, 5 Jul 2017 13:26:13 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.493 X-Spam-Level: X-Spam-Status: No, score=0.493 tagged_above=-999 required=5 tests=[AWL=-0.159, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LOGViTmyxoWG for ; Wed, 5 Jul 2017 13:26:12 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id CC7A46DE2530 for ; Wed, 5 Jul 2017 13:26:10 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 09974100086; Wed, 5 Jul 2017 23:26:19 +0300 (EEST) From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org, notmuch@freelists.org Subject: Re: [PATCH 07/23] test/crypto: mark extra space in userid as a bug in gmime-2.6 In-Reply-To: <20170603174754.16911-8-david@tethera.net> References: <20170603174754.16911-1-david@tethera.net> <20170603174754.16911-8-david@tethera.net> User-Agent: Notmuch/0.24+52~g1f96813 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Jul 2017 20:26:13 -0000 On Sat, Jun 03 2017, David Bremner wrote: > I can't see the space in the output of gpg -K --with-colons > --- > test/T350-crypto.sh | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/test/T350-crypto.sh b/test/T350-crypto.sh > index 0753acf3..720a2225 100755 > --- a/test/T350-crypto.sh > +++ b/test/T350-crypto.sh > @@ -69,6 +69,7 @@ test_expect_equal_json \ > "$expected" > > test_begin_subtest "signature verification with full owner trust" > +test_subtest_broken_gmime_2 > # give the key full owner trust > echo "${FINGERPRINT}:6:" | gpg --no-tty --import-ownertrust >>"$GNUPGHOME"/trust.log 2>&1 > gpg --no-tty --check-trustdb >>"$GNUPGHOME"/trust.log 2>&1 > @@ -90,7 +91,7 @@ expected='[[[{"id": "XXXXX", > "sigstatus": [{"status": "good", > "fingerprint": "'$FINGERPRINT'", > "created": 946728000, > - "userid": " Notmuch Test Suite (INSECURE!)"}], > + "userid": "Notmuch Test Suite (INSECURE!)"}], You could add a variable which is set to ' ' when gmime_2 is used and '' when gmime_3 is used and insert that just like '"$FINGERPRINT"' is added -- that change would not need to live there forever -- just couple of years until we drop support for gmime_2... ( ;) ) e.e. "userid: "'"$GM2SPC"'Notmuch Test Suite..." (if nimed as such, T350-crypto.sh -local variable) Tomi > "content-type": "multipart/signed", > "content": [{"id": 2, > "content-type": "text/plain", > @@ -276,6 +277,7 @@ test_expect_success \ > "(mml-secure-message-sign-encrypt)"' > > test_begin_subtest "decryption + signature verification" > +test_subtest_broken_gmime_2 > output=$(notmuch show --format=json --decrypt subject:"test encrypted message 002" \ > | notmuch_json_show_sanitize \ > | sed -e 's|"created": [1234567890]*|"created": 946728000|') > @@ -295,7 +297,7 @@ expected='[[[{"id": "XXXXX", > "sigstatus": [{"status": "good", > "fingerprint": "'$FINGERPRINT'", > "created": 946728000, > - "userid": " Notmuch Test Suite (INSECURE!)"}], > + "userid": "Notmuch Test Suite (INSECURE!)"}], > "content-type": "multipart/encrypted", > "content": [{"id": 2, > "content-type": "application/pgp-encrypted", > -- > 2.11.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch