From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 10F9A6DE0927
 for <notmuch@notmuchmail.org>; Tue, 29 Aug 2017 14:49:00 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.488
X-Spam-Level: 
X-Spam-Status: No, score=0.488 tagged_above=-999 required=5 tests=[AWL=-0.164, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id dpeKuMFDNM3x for <notmuch@notmuchmail.org>;
 Tue, 29 Aug 2017 14:48:58 -0700 (PDT)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id E9CEE6DE00DB
 for <notmuch@notmuchmail.org>; Tue, 29 Aug 2017 14:48:57 -0700 (PDT)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id ED8AB10008D
 for <notmuch@notmuchmail.org>; Wed, 30 Aug 2017 00:48:49 +0300 (EEST)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/3] build: add optional target parameter to quiet
 variable function
In-Reply-To: <20170829182709.26841-2-jani@nikula.org>
References: <20170829182709.26841-1-jani@nikula.org>
 <20170829182709.26841-2-jani@nikula.org>
User-Agent: Notmuch/0.25+52~ga6cef81 (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Wed, 30 Aug 2017 00:48:49 +0300
Message-ID: <m2bmmyniym.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Tue, 29 Aug 2017 21:49:00 -0000

On Tue, Aug 29 2017, Jani Nikula wrote:

> Sometimes using $@ as the target in the quiet build lines can be
> confusing. Accept an optional second parameter in the quiet variable
> function to specify the target.

+1 for 1/3, +1 for 3/3. this I did not quite understand (and don't bother
to figure out -- but I trust this works so +1 too)

Tomi


> ---
>  Makefile.local | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile.local b/Makefile.local
> index c51b9afb8fe6..2eb55e6ce1cd 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -182,11 +182,11 @@ verify-newer:
>  # user how to enable verbose compiles.
>  ifeq ($(V),)
>  quiet_DOC := "Use \"$(MAKE) V=1\" to see the verbose compile lines.\n"
> -quiet = @printf $(quiet_DOC)$(eval quiet_DOC:=)"$1 $@\n"; $($(word 1, $(1)))
> +quiet = @printf $(quiet_DOC)$(eval quiet_DOC:=)"$(1) $(or $(2),$@)\n"; $($(word 1, $(1)))
>  endif
>  # The user has explicitly enabled quiet compilation.
>  ifeq ($(V),0)
> -quiet = @printf "$1 $@\n"; $($(word 1, $(1)))
> +quiet = @printf "$(1) $(or $(2),$@)\n"; $($(word 1, $(1)))
>  endif
>  # Otherwise, print the full command line.
>  quiet ?= $($(word 1, $(1)))
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch