From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 154B56DE0350 for ; Mon, 4 Dec 2017 12:58:23 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.483 X-Spam-Level: X-Spam-Status: No, score=0.483 tagged_above=-999 required=5 tests=[AWL=-0.169, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id fQgAylUZyPo3 for ; Mon, 4 Dec 2017 12:58:21 -0800 (PST) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 826B86DE00D2 for ; Mon, 4 Dec 2017 12:58:21 -0800 (PST) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id C1325100104; Mon, 4 Dec 2017 22:58:18 +0200 (EET) From: Tomi Ollila To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH 1/5] debian/control: build-depend on python3-sphinx instead of python-sphinx In-Reply-To: <871skar2ec.fsf@fifthhorseman.net> References: <20171130094043.2039-1-dkg@fifthhorseman.net> <20171130094043.2039-2-dkg@fifthhorseman.net> <87k1y74zdb.fsf@fifthhorseman.net> <871skar2ec.fsf@fifthhorseman.net> User-Agent: Notmuch/0.25+89~g5a0c015 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 Dec 2017 20:58:23 -0000 On Mon, Dec 04 2017, Daniel Kahn Gillmor wrote: > On Sun 2017-12-03 15:35:04 +0200, Tomi Ollila wrote: >> On Thu, Nov 30 2017, Daniel Kahn Gillmor wrote: >> >>> On Thu 2017-11-30 04:40:39 -0500, Daniel Kahn Gillmor wrote: >>>> python2 is going to be deprecated, and python3-sphinx is available all >>>> the way back to oldoldstable. let's use the more modern version. >>>> --- >>>> debian/control | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/debian/control b/debian/control >>>> index 20b8a2db..3a624fdc 100644 >>>> --- a/debian/control >>>> +++ b/debian/control >>>> @@ -18,7 +18,7 @@ Build-Depends: >>>> python3-all (>= 3.1.2-7~), >>>> dh-python, >>>> dh-elpa (>= 1.3), >>>> - python-sphinx (>= 1.0), >>>> + python3-sphinx, >>>> ruby, ruby-dev (>>1:1.9.3~), >>>> emacs25-nox | emacs25 (>=25~) | emacs25-lucid (>=25~) | >>>> emacs24-nox | emacs24 (>=24~) | emacs24-lucid (>=24~) | >>> >>> hm, on further reflection, this one is specifically problematic because >>> of the use of: >>> >>> ${python} -m sphinx.writers.manpage >>> >>> in ./configure, used to test for the presence of the sphinx module. >>> >>> This can be fixed by preferring python3 here: >>> >>> --- a/configure >>> +++ b/configure >>> @@ -557,7 +557,7 @@ fi >>> printf "Checking for python... " >>> have_python=0 >>> >>> -for name in ${PYTHON} python python2 python3; do >>> +for name in ${PYTHON} python3 python python2; do >> >>> if command -v $name > /dev/null; then >>> have_python=1 >>> python=$name >>> >>> any thoughts or preferences on this? >> >> I'd like this change. I was going to suggest "${PYTHON}" there >> but perhaps if one sets e.g. >> >> PYTHON='/usr/local/bin/python3 -B -E -u' >> >> The above would still work (I'd say this is potentially more useful >> than supporting whitespace in paths). > > does it work? i think the -B -E -u will all be tried as possible python > implementations separately, no? and $python itself will just get set to > /usr/local/bin/python3 with the arguments dropped :( Ahh, you're right. Alternative would be to check whether "${PYTHON-}" is a nonempty string and use that... Tomi > > 0 dkg@alice:~$ x="a b c" > 0 dkg@alice:~$ for y in ${x} d e; do printf ':%s\n' "$y"; done > :a > :b > :c > :d > :e > 0 dkg@alice:~$ > > While i think this doesn't support Tomi's extended use case, i still > think it's the right direction to move in. > > Does anyone have any objection to the preference order change above? Is > there any reason we should be preferring python 2 to python3 as we move > forward? > > --dkg