From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 51D056DE0F4A
 for <notmuch@notmuchmail.org>; Sat,  9 Nov 2019 13:59:45 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.403
X-Spam-Level: 
X-Spam-Status: No, score=0.403 tagged_above=-999 required=5 tests=[AWL=-0.249, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id mF8sfDfzsNI5 for <notmuch@notmuchmail.org>;
 Sat,  9 Nov 2019 13:59:43 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 629406DE0EF2
 for <notmuch@notmuchmail.org>; Sat,  9 Nov 2019 13:59:42 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 32BC1100199;
 Sat,  9 Nov 2019 23:59:38 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/5] tests: run python-cffi tests
In-Reply-To: <8736exx23i.fsf@tethera.net>
References: <20191104013927.17037-1-david@tethera.net>
 <20191104013927.17037-5-david@tethera.net>
 <m21runiae8.fsf@guru.guru-group.fi> <87h83hsq4o.fsf@tethera.net>
 <m2wocc3ezl.fsf@guru.guru-group.fi> <8736exx23i.fsf@tethera.net>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Sat, 09 Nov 2019 23:59:37 +0200
Message-ID: <m2bltk1zjq.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Sat, 09 Nov 2019 21:59:45 -0000

On Fri, Nov 08 2019, David Bremner wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>>
>> Right -- just that pytest-3 may not be available -- to iterate (tested)...
>>
>> if ${NOTMUCH_PYTHON} -m pytest -c $conf --version >/dev/null 2>&1; then
>>
>
> The problem with this is that it might pass if pytest is only installed
> for python2. 

What is the minimum python3 version supported -- In the previous email thread all
references show python 3.7....

Anyway, in that wip/cffi "branch" commit 97caf16c15d (check for python cffi module)

could also include check for minimum python version, e.g.

+printf "Checking for python 3 cffi... "
+if "${NOTMUCH_PYTHON}" -c 'import sys,cffi; assert sys.version_info >= (3,7)' 2>/dev/null; then
+    printf "Yes.\n"
+    have_python3_cffi=1
+else
+    printf "No.\n"
+    have_python3_cffi=0
+fi

(adjust (3,7) above to any suitable smaller value =D)



Tomi

>
>> (in this particular case redirecting both stdout and stderr is needed
>>  to silence noise in all 'ordinary' cases, being 
>>    1) pytest module not available -- silence stderr
>>    2) pytest version not new enough -- silence stderr
>>    3) pytest exists and is new enought -- silence stdout )
>
> agreed
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch