From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 910536DE0A81
 for <notmuch@notmuchmail.org>; Thu, 27 Feb 2020 12:03:55 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: 0.391
X-Spam-Level: 
X-Spam-Status: No, score=0.391 tagged_above=-999 required=5 tests=[AWL=-0.261, 
 SPF_NEUTRAL=0.652] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id XEYGckyVtZ_Y for <notmuch@notmuchmail.org>;
 Thu, 27 Feb 2020 12:03:54 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
 by arlo.cworth.org (Postfix) with ESMTP id 5A06E6DE0A43
 for <notmuch@notmuchmail.org>; Thu, 27 Feb 2020 12:03:54 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
 by guru.guru-group.fi (Postfix) with ESMTP id 7B11E100063;
 Thu, 27 Feb 2020 22:03:52 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 4/6] Unthreaded mode: allow user to choose different
 `show out' than tree
In-Reply-To: <20200227171652.18187-5-markwalters1009@gmail.com>
References: <20200227171652.18187-1-markwalters1009@gmail.com>
 <20200227171652.18187-5-markwalters1009@gmail.com>
User-Agent: Notmuch/0.28.3+84~g41389bb (https://notmuchmail.org) Emacs/25.2.1
 (x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
 !)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 27 Feb 2020 22:03:52 +0200
Message-ID: <m2blpjer13.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 27 Feb 2020 20:03:55 -0000

On Thu, Feb 27 2020, Mark Walters wrote:

> Tree mode allows the user to choose whether to use the split screen
> displaying just the current message or a full screen displaying the
> entire thread. As unthreaded mode is quite different in use the user
> may want a different customisation for this mode.

LGTM.

Tomi


> ---
>  emacs/notmuch-tree.el | 14 ++++++++++++--
>  1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
> index 760eaaec..895c05f4 100644
> --- a/emacs/notmuch-tree.el
> +++ b/emacs/notmuch-tree.el
> @@ -56,6 +56,16 @@
>    :type 'boolean
>    :group 'notmuch-tree)
>  
> +(defcustom notmuch-unthreaded-show-out t
> +  "View selected messages in new window rather than split-pane."
> +  :type 'boolean
> +  :group 'notmuch-tree)
> +
> +(defun notmuch-tree-show-out ()
> +  (if notmuch-tree-unthreaded
> +      notmuch-unthreaded-show-out
> +    notmuch-tree-show-out))
> +
>  (defcustom notmuch-tree-result-format
>    `(("date" . "%12s  ")
>      ("authors" . "%-20s")
> @@ -531,8 +541,8 @@ NOT change the database."
>  Shows in split pane or whole window according to value of
>  `notmuch-tree-show-out'. A prefix argument reverses the choice."
>    (interactive "P")
> -  (if (or (and notmuch-tree-show-out  (not arg))
> -	  (and (not notmuch-tree-show-out) arg))
> +  (if (or (and (notmuch-tree-show-out) (not arg))
> +	  (and (not (notmuch-tree-show-out)) arg))
>        (notmuch-tree-show-message-out)
>      (notmuch-tree-show-message-in)))
>  
> -- 
> 2.11.0
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch