From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id 2MggAovYKmDfYwAA0tVLHw (envelope-from ) for ; Mon, 15 Feb 2021 20:24:43 +0000 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id qFCMOYrYKmCBBgAA1q6Kng (envelope-from ) for ; Mon, 15 Feb 2021 20:24:42 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 536711B601 for ; Mon, 15 Feb 2021 21:24:42 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id CA59B1FBAD; Mon, 15 Feb 2021 15:24:35 -0500 (EST) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id EDB5C1FAEF for ; Mon, 15 Feb 2021 15:24:31 -0500 (EST) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id A3DA41B001E8; Mon, 15 Feb 2021 22:24:30 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613420670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CPhogELrsfOxHBHeQG0oMDFj1C8pp02G0BnHZRcq8C0=; b=CYMAZX1POH0KzodiXvzz5Ack3ZBx5KR6G4+i2rmN5vpdPSrwDb7LGWPRQAsh7JoB6KVenI RfwSNgHFli/gOl1Ve/AtrmIpA7dZLonte+1/PrBXWGpIdZP96QUTRoFte+mXu1fAL9rNYR YeU4KDfph+waxN6WGBLBbbygWvUV7cxxt5mCClnirfMggL5TS8CDOqPG8TxL+sdjjReWOP VGF1y9mnanYZAreHWLqYUsuQhScvXzXX0JQF97RUYZOs+f1SzcB7eyl3toGlrAbLiiUvd9 90VYggYx9lKsN1q/C4obDbNLsYRRAXDIaSQB3zcLF9nL7B4jUVmF83SSVkbeuA== From: Tomi Ollila To: David Bremner , notmuch@notmuchmail.org Cc: David Bremner Subject: Re: [PATCH] test: Fix race condition in T568-lib-thread.sh In-Reply-To: <20210215005555.4038380-1-david@tethera.net> References: <20210215005555.4038380-1-david@tethera.net> User-Agent: Notmuch/0.31.3+85~g92bd77f (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1613420670; a=rsa-sha256; cv=none; b=EMnX5IGEgTwJxVkZZFfttMugTR4iRZD7++iUX6LA8aOoonhtWGGIFzkh81PnSy+4j1nKpa YSjd8yDf90UcSZvSGG7Jm52Fn5XttNw8iRYwuFMzA9ZxWEseC4fdf6CU3VIVkkFqp8UiwB /qZtlvuQ2z7rdWqEbAKK7yMrKZOGmJqiXViP8uvKbiWglbniu9pm/VGROmgsKJUhRqh6/0 OhR+/7j2myGq2L/p6JhMk18A/x5ZvG2LpI2UeStHK5CADjFTBJBzOvnAgJbvRDRmWIZ/eD 0frRpeFloVYeQesGKLfg9/SukTFPClGgaceKk6EeVm8BIHUPaWWSk4h6x/HP6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1613420670; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=CPhogELrsfOxHBHeQG0oMDFj1C8pp02G0BnHZRcq8C0=; b=S+FkSKfD/PTGK5rrrgUSBRSO//i8a2gt7vixCdax0mbIkXO1MSoHIVCJz6DBMuvXfOpPe5 UMjO1JHuHfNx3WhZmWsdIGHkBHgLKyzrgchZyoKFCeXWGnWmYBUl4e6Zf3lUDBrlGzMDIy mNSCjzYArByhhFoT1nGNVeK+5nJIuOSZlQqDYVmm2vz8HimfGbpENre3q5BnafpkUQD3af qsF4ckex2Ncz7ybiLDGwjDqhZ1mD01GOsbXDCvfje6OZUKucJJVZwy8RZyGAKFtthGv7vT Owric3TuDSghVGTi2tC3eG1rwPLiVvFRxHDjM7UDAfUtS75NHiGtFoSMWJvpvQ== Message-ID-Hash: DCC7XXKIP34YINZM6ETVXTZ2EC6JP3PL X-Message-ID-Hash: DCC7XXKIP34YINZM6ETVXTZ2EC6JP3PL X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: 2.46 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=CYMAZX1P; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 536711B601 X-Spam-Score: 2.46 X-Migadu-Scanner: scn1.migadu.com X-TUID: IyENEumcP8BU On Sun, Feb 14 2021, David Bremner wrote: > The assignment of thread-ids is (apparently) non-deterministic in a > way that mostly seems to show up on multicore machines. In my tests > the number is different from that previously assumed by this test > about 15% of the time on a 50 thread (25 core) Xeon. > > Since message id's are fixed, use a message known to be in the thread > of interest to pick out the correct thread-id. LGTM. Tomi > --- > test/T568-lib-thread.sh | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/test/T568-lib-thread.sh b/test/T568-lib-thread.sh > index ac13d986..088e66dd 100755 > --- a/test/T568-lib-thread.sh > +++ b/test/T568-lib-thread.sh > @@ -8,6 +8,11 @@ add_email_corpus > test_begin_subtest "building database" > test_expect_success "NOTMUCH_NEW" > > +test_begin_subtest "finding thread" > +THREAD=$(notmuch search --output=threads id:20091117190054.GU3165@dottiness.seas.harvard.edu) > +count=$(notmuch count $THREAD) > +test_expect_equal "$count" "7" > + > cat <<'EOF' > c_tail > if (stat) { > const char *stat_str = notmuch_database_status_string (db); > @@ -30,7 +35,7 @@ int main (int argc, char** argv) > notmuch_thread_t *thread = NULL; > notmuch_threads_t *threads = NULL; > notmuch_query_t *query = NULL; > - const char *id = "thread:0000000000000009"; > + const char *id = "${THREAD}"; > > stat = notmuch_database_open_verbose (argv[1], NOTMUCH_DATABASE_MODE_READ_WRITE, &db, &msg); > if (stat != NOTMUCH_STATUS_SUCCESS) { > @@ -52,10 +57,11 @@ cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} > printf("%d\n%s\n", thread != NULL, id2); > } > EOF > +thread_num=${THREAD#thread:} > cat < EXPECTED > == stdout == > 1 > -0000000000000009 > +${thread_num} > == stderr == > EOF > test_expect_equal_file EXPECTED OUTPUT > -- > 2.30.0 > _______________________________________________ > notmuch mailing list -- notmuch@notmuchmail.org > To unsubscribe send an email to notmuch-leave@notmuchmail.org