unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Leo Okawa Ericson <git@relevant-information.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread
Date: Tue, 03 May 2022 17:20:24 +0300	[thread overview]
Message-ID: <m2bkwey9xz.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20220502151849.6364-1-git@relevant-information.com>

On Mon, May 02 2022, Leo Okawa Ericson wrote:

> ---
>  emacs/notmuch.el | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
> index c9cf80dc..c1ddb06b 100644
> --- a/emacs/notmuch.el
> +++ b/emacs/notmuch.el
> @@ -525,13 +525,13 @@ (defun notmuch-search-show-thread (&optional elide-toggle)
>    (let ((thread-id (notmuch-search-find-thread-id)))
>      (if thread-id
>  	(notmuch-show thread-id
> -		      elide-toggle
> -		      (current-buffer)
> -		      notmuch-search-query-string
> -		      ;; Name the buffer based on the subject.
> -		      (format "*%s*" (truncate-string-to-width
> -				      (notmuch-search-find-subject)
> -				      30 nil nil t)))

To me it looks like this change "breaks" indentation -- the original
where all function (notmuch-show) arguments are aligned vertically,
starting from same column in each line...???

> +	       elide-toggle
> +	       (current-buffer)
> +	       notmuch-search-query-string
> +	       ;; Name the buffer based on the subject.
> +	       (format "*%s*" (truncate-string-to-width
> +			       (notmuch-search-find-subject)
> +			       30 nil nil t)))
>        (message "End of search results."))))
>  
>  (defun notmuch-tree-from-search-current-query ()
>
> base-commit: e3ad0087f3453c89871acac8b11da8bab1ac54df

btw: what is this 'base commit:' line ?

Tomi

> -- 
> 2.36.0

  parent reply	other threads:[~2022-05-03 14:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-02 15:18 [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread Leo Okawa Ericson
2022-05-02 15:18 ` [PATCH v2 2/2] emacs: Make notmuch-show-next-thread return nil on failure Leo Okawa Ericson
2022-05-03 14:20 ` Tomi Ollila [this message]
2022-05-03 14:56   ` [PATCH v2 1/2] emacs: Make indentation more consistent in notmuch-search-show-thread Leo Okawa Ericson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2bkwey9xz.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=git@relevant-information.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).