From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id KAfrJjuaLGS/DwEASxT56A (envelope-from ) for ; Tue, 04 Apr 2023 23:44:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id 2KrEJjuaLGTgUAAAauVa8A (envelope-from ) for ; Tue, 04 Apr 2023 23:44:27 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 01A8347054 for ; Tue, 4 Apr 2023 23:44:26 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 961EC5F823; Tue, 4 Apr 2023 21:44:24 +0000 (UTC) Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by mail.notmuchmail.org (Postfix) with ESMTPS id 5958F5F7EB for ; Tue, 4 Apr 2023 21:44:22 +0000 (UTC) Received: by mail-wm1-x32d.google.com with SMTP id d11-20020a05600c3acb00b003ef6e6754c5so17181327wms.5 for ; Tue, 04 Apr 2023 14:44:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680644661; h=mime-version:message-id:date:in-reply-to:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=P1tVMSCe7NZLPuazIjUTL1e+tix/+sFF/r8KZMGGGFQ=; b=UivJ9RLrPqluLObKaOUMbYS/7t9Q8T5NUhrvdLlKAweXt5B23xhbY4KeDHPaGsnciZ NQkNp02XvF1wPB2wx23uLxaRtCojao8jcqYIDYLBYVW7WKYLiyI2Te3dxEXfRAuTOOzA 8pTZJ6UTr5b0pA8BuzSvUimCocP+oyUymUx2tFDaBtKC8iIz6lQG1kBl+Ms/k8UBmw9r BZNvYNdcLkZU4A+SWD3r84zFLDHeabJhEunm0KGXh8kT08gMy/Hgj9hKGbuMjVKOc5hX YZN/ibrQ5FBvHHrVWLBq1NkCp4/MBIa7AVmeO3UOg3jsovfecvU2ojxiuhQMzunrQD1I Aj/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680644661; h=mime-version:message-id:date:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=P1tVMSCe7NZLPuazIjUTL1e+tix/+sFF/r8KZMGGGFQ=; b=QP8ev/cluvxg2rFyetW2p7i61I11gaYY08NzkJ7tH3qU7CjZ5dPWHoMCMD/+RPtAw8 0CJLomJeslAHyUYz+4b1u0CZPr/pWZwyjBcXt0l88WtoEuly4NFHsxb6sPnog4h8WBJX NxpqP1uuyx+6QedPXu6SHe3uz3Y08o+azp3nYHhNaFylXdZbdTvoWHcaaVZE5TCi1uIc dWetFzl4fLpxgYO+lRxobFPP4SJB6aWtgPq4i3dBiEVGKHHCuFZz50TdlUTy40Wn67kX snlANaIe5mV2Qi2jqqpisF4SERg3i+BV9DvAcBjhbMDic7y2rhwEptEGSDAimPOCoYrY Mp0A== X-Gm-Message-State: AAQBX9eBgmjHxtvOBskifotrtxCjd7BqO7U8AEXgjp/zFYR9bXxdqPtI Rbp63BfdPhgyGXs/U9Rp6MyIAg9P3586KA== X-Google-Smtp-Source: AKy350aeYkoqJb4/sRZeqNAK4aenwB6Pp+t3ulgd63KoReDm/fFtAiYQZfqonBS3Qq5WVDt8z1IFhg== X-Received: by 2002:a7b:cd87:0:b0:3df:de28:f819 with SMTP id y7-20020a7bcd87000000b003dfde28f819mr3278888wmj.15.1680644661332; Tue, 04 Apr 2023 14:44:21 -0700 (PDT) Received: from localhost (sgyl-45-b2-v4wan-165314-cust948.vm6.cable.virginm.net. [92.236.87.181]) by smtp.gmail.com with ESMTPSA id q25-20020a7bce99000000b003edc11c2ecbsm168991wmj.4.2023.04.04.14.44.20 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Apr 2023 14:44:20 -0700 (PDT) From: Al Haji-Ali To: notmuch@notmuchmail.org Subject: Re: notmuch-emacs inline image display broken in emacs-29 In-Reply-To: <87pm9r6fg9.fsf@graphene.mail-host-address-is-not-set> Date: Tue, 04 Apr 2023 22:44:14 +0100 Message-ID: MIME-Version: 1.0 Message-ID-Hash: RW3BYOSKOO6Y4CBEGZOMCUAKKEIF5Y54 X-Message-ID-Hash: RW3BYOSKOO6Y4CBEGZOMCUAKKEIF5Y54 X-MailFrom: abdo.haji.ali@gmail.com X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0 X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1680644667; a=rsa-sha256; cv=none; b=Vfu7TYE8OOxgrSAbPkVn19k5w7H2/opegJ50wWEQ+QV7mI1T7tsLsAlRP4MUjJ3rrfBWk2 1lbIhThdNE7ohM5qN2gkY6gHfdRZf3kZeaQcdYh105wWs19KpFMpWYZTQo+y8LRaWZcPrN 6dbxQq1KLjEegnKtKeZHuWL2NDU9gmuWPOsjmon86kvV5EgBiKKZXMC0nH4+xqiKdOj4B/ qQtdT82tgYXkMdmS7HsbReY4rDBCW0vR9gqZsKLHVPjisgAh3Ysqx0OC+ugXzqWcbaZO7E P4YtiD+brTCBwe1P+BF1tAkZDaxQ4lVI+3tXfJ7nYGrorEfhzGD7blgAQfdh8A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=UivJ9RLr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1680644667; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:list-id:list-help:list-owner:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=z4TK1PzjPi1BcRDAY7u78YHZfV7U496ZV+kxIcWD4a0=; b=qpkYaU/SKpjkKYB8vZAmCp7bV+G3oikpgGgOzeuuSE7msGB2yvD0/5GTutpDxui2cH5MzH 7F0XobbzFqp1ZbIgXS/SyHHyAS2pPJYYA7T/Le9fHMy1dGYOTHczEhimxOtxttktRLG2TS 5T12z/idrJupRZfHuERHzoDRJ3NovQ7/qg7DQ/9WyjP9jkAJkYUCtola4w61bwjSxTNT0q jzrBZ6UP5+lK0C9ib0hJ2EeqYbXyDYLa6r6DX2A0jxMr/9sLONzKED+uTNHewvDN9yQFTI STr1CVcU0ScM5ZCw2wA45r0MqvPdbmftDaJ12rXtV5myUu+FJG5qseLIAqTkwQ== X-Migadu-Spam-Score: 7.08 X-Migadu-Scanner: scn1.migadu.com Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=gmail.com header.s=20210112 header.b=UivJ9RLr; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Spam-Score: 7.08 X-Migadu-Queue-Id: 01A8347054 X-TUID: GACzftnE2XCP Hello Alex and David, I also came across this issue: inline image are not displayed only when `notmuch-show-indent-content` is non-nil. However, even when `notmuch-show-indent-content` is `nil` they are displayed but cannot be hidden. As Alex Murray pointed out, the reason is that the function `mm-insert-image` is being changed in Emacs 29 to use `insert-image` instead of `put-image`. `insert-image` inserts images using the `display` property of a whitespace character. The effect is that when `indent-rigidly` is called in `notmuch-show-insert-msg`, whitespace is removed and hence the image is removed. I've filed a bug#62637 on bug-gnu-emacs to discuss this. An easy fix in `mm-insert-image` is use non-whitespace character (the second argument of `insert-image`) so that it is not deleted by `indent-rigidly`. This change actually makes indenting images work in the new version. The other issue is that hiding an overlay created around such an image does not seem to work (see bug#62637 for a discussion). A way to resolve this is to add some whitespace (like a newline) inside the overlay before the image, which seems to fix things. -- Al