From: Xavier Maillard <xavier@maillard.im>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests
Date: Mon, 23 Jan 2012 20:05:06 +0100 [thread overview]
Message-ID: <m2aa5e2qal.fsf@kcals.intra.maillard.im> (raw)
In-Reply-To: <1309236311-2162-8-git-send-email-dmitry.kurochkin@gmail.com>
On Tue, 28 Jun 2011 08:45:09 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Using `setq' for setting variables in Emacs tests affect other
> tests that may run in the same Emacs environment. Currently it
> works because each test is run in a separate Emacs instance. But
> in the future multiple tests will run in a single Emacs instance.
> The patch changes all variables to use `let', so the scope of the
> change is limited to a single test.
+1 (definetely)
/Xavier
next prev parent reply other threads:[~2012-01-23 19:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-28 4:45 [PATCH 01/10] test: fix argument order of test_expect_equal_file in few tests Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 02/10] test: do not set `message-signature' in test_emacs Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 03/10] test: cleanup test_emacs Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 04/10] test: wrap and indent test_emacs calls Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 05/10] test: save buffer content to file instead of printing it in Emacs tests Dmitry Kurochkin
2012-01-23 4:26 ` [PATCH] test/emacs-large-search-buffer: correct typo (EXPEXTED -> EXPECTED) Pieter Praet
2012-01-23 11:48 ` David Bremner
2011-06-28 4:45 ` [PATCH 06/10] test: remove some sed(1) calls in Emacs tests Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 07/10] test: use emacs_deliver_message in Emacs SMTP send test Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests Dmitry Kurochkin
2012-01-23 19:05 ` Xavier Maillard [this message]
2011-06-28 4:45 ` [PATCH 09/10] test: generate run_emacs script once on test startup Dmitry Kurochkin
2011-06-28 4:45 ` [PATCH 10/10] test: use emacsclient(1) for Emacs tests Dmitry Kurochkin
2011-06-28 4:56 ` [PATCH] " Dmitry Kurochkin
2011-06-28 22:14 ` [PATCH 10/10] " Carl Worth
2011-06-28 22:22 ` Dmitry Kurochkin
2011-06-29 0:15 ` Carl Worth
2011-06-29 7:34 ` Austin Clements
2011-06-29 14:20 ` Carl Worth
2012-01-23 19:08 ` Xavier Maillard
2012-01-25 0:47 ` Pieter Praet
2012-01-25 1:01 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2aa5e2qal.fsf@kcals.intra.maillard.im \
--to=xavier@maillard.im \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
--cc=xma@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).