unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Subject: Re: [PATCH 0/9] Fix directory lookup on read-only databases
Date: Tue, 22 May 2012 23:48:00 +0300	[thread overview]
Message-ID: <m2aa10uem7.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1337314423-3702-1-git-send-email-amdragon@mit.edu>

Austin Clements <amdragon@MIT.EDU> writes:

> This fixes notmuch_database_get_directory and
> notmuch_database_find_message_by_filename so that they don't attempt
> to create missing directory documents.  This makes them work on
> read-only databases (and prevents n_d_f_m_b_f from crashing
> unceremoniously on read-only databases).
>
> Unfortunately, there are several functions involved in directory
> document lookup, so the first three patches simply add a creation flag
> at each necessary layer.  The remaining patches then fix up the two
> API functions and their uses.
>
> If we do a 0.13.1 bug fix release, these patches could go in to
> complement the API changes made in 0.13 to support these fixes.  David
> can make that call.
>
> There are several patches, but they're all short and incremental.

This patch series looks good to me...


Tomi


>
>  bindings/python/notmuch/database.py |   11 -----------
>  lib/database.cc                     |   40 +++++++++++++++++++++++++---------------
>  lib/directory.cc                    |   41 +++++++++++++++++++++++++++++++++++------
>  lib/message.cc                      |   11 +++++------
>  lib/notmuch-private.h               |   13 +++++++++++++
>  lib/notmuch.h                       |   10 ++--------
>  notmuch-new.c                       |   36 +++++++-----------------------------
>  test/python                         |    8 ++++++++
>  8 files changed, 95 insertions(+), 75 deletions(-)
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2012-05-22 20:48 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-18  4:13 [PATCH 0/9] Fix directory lookup on read-only databases Austin Clements
2012-05-18  4:13 ` [PATCH 1/9] lib: Make directory document creation optional for _notmuch_directory_create Austin Clements
2012-05-24  1:53   ` David Bremner
2012-05-18  4:13 ` [PATCH 2/9] lib: Perform the same transformation to _notmuch_database_find_directory_id Austin Clements
2012-05-18  4:13 ` [PATCH 3/9] lib: Perform the same transformation to _notmuch_database_filename_to_direntry Austin Clements
2012-05-18  4:13 ` [PATCH 4/9] lib: Make notmuch_database_get_directory return NULL if the directory is not found Austin Clements
2012-05-18  4:13 ` [PATCH 5/9] new: Remove workaround for detecting newly created directory objects Austin Clements
2012-05-18  4:13 ` [PATCH 6/9] python: Update Database.get_directory documentation Austin Clements
2012-05-18  4:13 ` [PATCH 7/9] lib: Make notmuch_database_find_message_by_filename not crash on read-only databases Austin Clements
2012-05-18  4:13 ` [PATCH 8/9] python: Remove find_message_by_filename workaround Austin Clements
2012-05-18  4:13 ` [PATCH 9/9] lib: Don't needlessly create directory docs in _notmuch_message_remove_filename Austin Clements
2012-05-22 20:48 ` Tomi Ollila [this message]
2012-05-23 10:28 ` [PATCH 0/9] Fix directory lookup on read-only databases Justus Winter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2aa10uem7.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=amdragon@MIT.EDU \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).