* [PATCH v2 0/2] Enhancements to notmuch-hello search history
@ 2013-06-07 20:53 Servilio Afre Puentes
2013-06-07 20:55 ` [PATCH v2 1/2] emacs: hello: ask confirmation for clearing recent searches Servilio Afre Puentes
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Servilio Afre Puentes @ 2013-06-07 20:53 UTC (permalink / raw)
To: notmuch
Hi,
Two patches that enhance the notmuch-hello search history UI. Though
minor changes, I find them very helpful.
This second iteration includes the modifications suggested by Jani and
Tomi.
Servilio Afre Puentes (2):
emacs: hello: ask confirmation for clearing recent searches
emacs: hello: allow deleting individual searches in the history
emacs/notmuch-hello.el | 30 ++++++++++++++++++++++++++----
1 file changed, 26 insertions(+), 4 deletions(-)
--
1.8.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2 1/2] emacs: hello: ask confirmation for clearing recent searches
2013-06-07 20:53 [PATCH v2 0/2] Enhancements to notmuch-hello search history Servilio Afre Puentes
@ 2013-06-07 20:55 ` Servilio Afre Puentes
2013-06-07 20:57 ` [PATCH v2 2/2] emacs: hello: allow deleting individual searches in the history Servilio Afre Puentes
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Servilio Afre Puentes @ 2013-06-07 20:55 UTC (permalink / raw)
To: notmuch
The button to clear the recent searches in notmuch-hello is easy to
press accidentally while moving around the, clearing potentially
useful searches with no way of recovering them.
---
emacs/notmuch-hello.el | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index c1c6f4b..1ad1bea 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -599,8 +599,9 @@ Complete list of currently available key bindings:
(widget-insert "Recent searches: ")
(widget-create 'push-button
:notify (lambda (&rest ignore)
- (setq notmuch-search-history nil)
- (notmuch-hello-update))
+ (when (y-or-n-p "Are you sure you want to clear the searches? ")
+ (setq notmuch-search-history nil)
+ (notmuch-hello-update)))
"clear")
(widget-insert "\n\n")
(let ((start (point)))
--
1.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] emacs: hello: allow deleting individual searches in the history
2013-06-07 20:53 [PATCH v2 0/2] Enhancements to notmuch-hello search history Servilio Afre Puentes
2013-06-07 20:55 ` [PATCH v2 1/2] emacs: hello: ask confirmation for clearing recent searches Servilio Afre Puentes
@ 2013-06-07 20:57 ` Servilio Afre Puentes
2013-06-07 21:24 ` [PATCH v2 0/2] Enhancements to notmuch-hello search history Tomi Ollila
2013-06-09 0:10 ` David Bremner
3 siblings, 0 replies; 5+ messages in thread
From: Servilio Afre Puentes @ 2013-06-07 20:57 UTC (permalink / raw)
To: notmuch
This commit adds an extra button at the end of the search entries that
allows deleting that individual search from the history. A short
confirmation («y» or «n») is made before taking action.
---
emacs/notmuch-hello.el | 25 +++++++++++++++++++++++--
1 file changed, 23 insertions(+), 2 deletions(-)
diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
index 1ad1bea..147c08c 100644
--- a/emacs/notmuch-hello.el
+++ b/emacs/notmuch-hello.el
@@ -286,6 +286,15 @@ afterwards.")
(message "Saved '%s' as '%s'." search name)
(notmuch-hello-update)))
+(defun notmuch-hello-delete-search-from-history (widget)
+ (interactive)
+ (let ((search (widget-value
+ (symbol-value
+ (widget-get widget :notmuch-saved-search-widget)))))
+ (setq notmuch-search-history (delete search
+ notmuch-search-history))
+ (notmuch-hello-update)))
+
(defun notmuch-hello-longest-label (searches-alist)
(or (loop for elem in searches-alist
maximize (length (car elem)))
@@ -624,7 +633,12 @@ Complete list of currently available key bindings:
;; `[save]' button. 6
;; for the `[save]'
;; button.
- 1 6))
+ 1 6
+ ;; 1 for the space
+ ;; before the `[del]'
+ ;; button. 5 for the
+ ;; `[del]' button.
+ 1 5))
:action (lambda (widget &rest ignore)
(notmuch-hello-search (widget-value widget)))
search))
@@ -633,7 +647,14 @@ Complete list of currently available key bindings:
:notify (lambda (widget &rest ignore)
(notmuch-hello-add-saved-search widget))
:notmuch-saved-search-widget widget-symbol
- "save"))
+ "save")
+ (widget-insert " ")
+ (widget-create 'push-button
+ :notify (lambda (widget &rest ignore)
+ (when (y-or-n-p "Are you sure you want to delete this search? ")
+ (notmuch-hello-delete-search-from-history widget)))
+ :notmuch-saved-search-widget widget-symbol
+ "del"))
(widget-insert "\n"))
(indent-rigidly start (point) notmuch-hello-indent))
nil))
--
1.8.3
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] Enhancements to notmuch-hello search history
2013-06-07 20:53 [PATCH v2 0/2] Enhancements to notmuch-hello search history Servilio Afre Puentes
2013-06-07 20:55 ` [PATCH v2 1/2] emacs: hello: ask confirmation for clearing recent searches Servilio Afre Puentes
2013-06-07 20:57 ` [PATCH v2 2/2] emacs: hello: allow deleting individual searches in the history Servilio Afre Puentes
@ 2013-06-07 21:24 ` Tomi Ollila
2013-06-09 0:10 ` David Bremner
3 siblings, 0 replies; 5+ messages in thread
From: Tomi Ollila @ 2013-06-07 21:24 UTC (permalink / raw)
To: Servilio Afre Puentes, notmuch
On Fri, Jun 07 2013, Servilio Afre Puentes <servilio@gmail.com> wrote:
> Hi,
>
> Two patches that enhance the notmuch-hello search history UI. Though
> minor changes, I find them very helpful.
>
> This second iteration includes the modifications suggested by Jani and
> Tomi.
This series LGTM and works fine.
Tomi
>
> Servilio Afre Puentes (2):
> emacs: hello: ask confirmation for clearing recent searches
> emacs: hello: allow deleting individual searches in the history
>
> emacs/notmuch-hello.el | 30 ++++++++++++++++++++++++++----
> 1 file changed, 26 insertions(+), 4 deletions(-)
>
> --
> 1.8.3
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 0/2] Enhancements to notmuch-hello search history
2013-06-07 20:53 [PATCH v2 0/2] Enhancements to notmuch-hello search history Servilio Afre Puentes
` (2 preceding siblings ...)
2013-06-07 21:24 ` [PATCH v2 0/2] Enhancements to notmuch-hello search history Tomi Ollila
@ 2013-06-09 0:10 ` David Bremner
3 siblings, 0 replies; 5+ messages in thread
From: David Bremner @ 2013-06-09 0:10 UTC (permalink / raw)
To: Servilio Afre Puentes, notmuch
Servilio Afre Puentes <servilio@gmail.com> writes:
> Hi,
>
> Two patches that enhance the notmuch-hello search history UI. Though
> minor changes, I find them very helpful.
>
pushed, thanks
d
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-06-09 0:30 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-07 20:53 [PATCH v2 0/2] Enhancements to notmuch-hello search history Servilio Afre Puentes
2013-06-07 20:55 ` [PATCH v2 1/2] emacs: hello: ask confirmation for clearing recent searches Servilio Afre Puentes
2013-06-07 20:57 ` [PATCH v2 2/2] emacs: hello: allow deleting individual searches in the history Servilio Afre Puentes
2013-06-07 21:24 ` [PATCH v2 0/2] Enhancements to notmuch-hello search history Tomi Ollila
2013-06-09 0:10 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).