From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tomi.ollila@iki.fi>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id C356D431FC7
	for <notmuch@notmuchmail.org>; Thu,  1 Jan 2015 04:13:00 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
X-Spam-Flag: NO
X-Spam-Score: 0
X-Spam-Level: 
X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
	autolearn=disabled
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id x1dqUw-aSf1f for <notmuch@notmuchmail.org>;
	Thu,  1 Jan 2015 04:12:57 -0800 (PST)
Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
	by olra.theworths.org (Postfix) with ESMTP id 73E86431FC0
	for <notmuch@notmuchmail.org>; Thu,  1 Jan 2015 04:12:57 -0800 (PST)
Received: from guru.guru-group.fi (localhost [IPv6:::1])
	by guru.guru-group.fi (Postfix) with ESMTP id 32738100051;
	Thu,  1 Jan 2015 14:12:30 +0200 (EET)
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] completion: complete notmuch insert --folder to
 maildir	folders only
In-Reply-To: <871tnfh7yt.fsf@maritornes.cs.unb.ca>
References: <1415648143-19923-1-git-send-email-jani@nikula.org>
	<1415648143-19923-2-git-send-email-jani@nikula.org>
	<871tnfh7yt.fsf@maritornes.cs.unb.ca>
User-Agent: Notmuch/0.19+6~g8725b09 (http://notmuchmail.org) Emacs/24.3.1
	(x86_64-unknown-linux-gnu)
X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
	$[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
	!)g;OY^,BjTbr)Np:%c_o'jj,Z
Date: Thu, 01 Jan 2015 14:12:30 +0200
Message-ID: <m2a922hf81.fsf@guru.guru-group.fi>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.13
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Thu, 01 Jan 2015 12:13:01 -0000

On Wed, Dec 31 2014, David Bremner <david@tethera.net> wrote:

> Jani Nikula <jani@nikula.org> writes:
>> +	    local path=`notmuch config get database.path`
>> +	    compopt -o nospace
>> +	    COMPREPLY=( $(compgen -d "$path/${cur##folder:}" | \
>> +		sed "s|^$path/||" | grep -v "\(^\|/\)\(cur\|new\|tmp\)$"
>
> I'm a bit confused here. Why is 'folder:' being stripped? Too much
> copy-pasta?

compgen -d wants a directory ?

there seems to be similar strippings done in completion of
notmuch_search_terms.

>
> d

Tomi

PS: if it weren't inconsistent change, just on '#' would suffice ;)