unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] build: add "set -e" to version script generation
Date: Mon, 27 Jul 2015 22:36:23 +0300	[thread overview]
Message-ID: <m2a8uh75qg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1438022552-24342-1-git-send-email-david@tethera.net>

On Mon, Jul 27 2015, David Bremner <david@tethera.net> wrote:

> It turns out that on certain systems like FreeBSD, c++filt is not
> installed by default. It's basically OK if we fail the build in that
> case, but what's really not OK is for the build to continue and
> generate bad binaries.
> ---
>  lib/gen-version-script.sh | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/gen-version-script.sh b/lib/gen-version-script.sh
> index 64a7374..aa1ca43 100644
> --- a/lib/gen-version-script.sh
> +++ b/lib/gen-version-script.sh
> @@ -1,3 +1,4 @@
> +set -e

LGTM, although I'd prefer 'set -eu' (both visual observation and testing
with set -eux worked for me).

Tomi


>  
>  # we go through a bit of work to get the unmangled names of the
>  # typeinfo symbols because of
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

  reply	other threads:[~2015-07-27 19:36 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 18:42 [PATCH] build: add "set -e" to version script generation David Bremner
2015-07-27 19:36 ` Tomi Ollila [this message]
2015-07-28 19:41   ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m2a8uh75qg.fsf@guru.guru-group.fi \
    --to=tomi.ollila@iki.fi \
    --cc=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).