From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] emacs: tag-jump: make k binding for the reverse tag change map
Date: Thu, 06 Oct 2016 21:23:50 +0300 [thread overview]
Message-ID: <m2a8eh2v61.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1475765990-15031-1-git-send-email-markwalters1009@gmail.com>
On Thu, Oct 06 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> Currently, by default k invokes the tag-jump menu, and following it by
> r invokes the reverse tag change jump menu. This is awkward to type
> (e.g. k r u for undoing a -unread change). This changes it so that k
> followed by k invokes the reverse menu.
> ---
>
> There has been discussion on irc and reasonable agreement that this is
> more convenient.
>
> This patch can be applied on its own, or with the second patch. Since
> it is relatively hard to configure the internal binding to jump to the
> reverse tag changes it might be worth applying. Alternatively we could
> have a defvar variable that specifies the key, so a user can configure
> it if they want.
>
> Since the first patch changes default keybindigs it is probably worth
> applying that one soon, and then considering what, if anything, to do
> about the second.
Agreed -- and putting the "k" into a variable can also be applied
separately.
>
> Best wishes
>
> Mark
>
>
>
>
>
> emacs/notmuch-tag.el | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 49662c2..36a498d 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -523,7 +523,7 @@ and vice versa."
> (push (list key name-string
> `(lambda () (,tag-function ',tag-change)))
> action-map)))
> - (push (list "r" (if reverse
> + (push (list "k" (if reverse
> "Forward tag changes "
> "Reverse tag changes")
> (apply-partially 'notmuch-tag-jump (not reverse)))
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-10-06 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:59 [PATCH 1/2] emacs: tag-jump: make k binding for the reverse tag change map Mark Walters
2016-10-06 14:59 ` [PATCH 2/2] emacs: tag-jump: make the same binding do " Mark Walters
2016-10-06 18:23 ` Tomi Ollila [this message]
2016-10-06 21:59 ` [PATCH] emacs: tag-jump: make k binding for " Mark Walters
2016-10-07 20:21 ` Tomi Ollila
2016-10-08 1:41 ` David Bremner
2016-10-08 15:05 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2a8eh2v61.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).