From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 8I04AwzfZmFCNAEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 15:28:44 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id OCeJOgvfZmGbOQAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 13:28:43 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8A58B284A7 for ; Wed, 13 Oct 2021 15:28:43 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5EE6C2C189; Wed, 13 Oct 2021 09:28:40 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 5F84B2C183 for ; Wed, 13 Oct 2021 09:28:37 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 14CCC1B0023A; Wed, 13 Oct 2021 16:28:33 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1634131713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NHX9P+hP8BM/JHT9XQUjzULYdEqVTyzyaOesbWe0xaw=; b=EhjefM7bLEUFlyaTquGt+bvIlRMSbkbFqIou0/vb12M1B44Rdi4JF9iUY/Z8Pq5RKRiekz qCEw1V/8OM00O3hAdyQj6gKjKpxQADp0fPjnCYq9WBAh/60WuQC2dII35YCKXV9tkTcV+3 s8WJIwIipiElK2sl/nw6fsQrbGY9nTyPqjAOjLnuV4vPqZCXn9u4gY+hnY6YbgKZEASntJ DwXSGHLJ2NgtAY/ia3NmPUN/iSy+pm3WSUKbv4KgXIVUzA4B+n2o7xtBAR/i66s9ZmXH/t Mmok/C0PSjokrVX4gXCEsn3tB1MpE3nKQ0SmqawmvaF3iiUyL8Nx3rbWDqmdUw== From: Tomi Ollila To: David Bremner , Jani Nikula , notmuch@notmuchmail.org Cc: jani@nikula.org Subject: Re: [RFC 2/5] lib: remove enum names from typedefs In-Reply-To: <87y26xkqql.fsf@tethera.net> References: <20211012185127.198348-1-jani@nikula.org> <20211012185127.198348-3-jani@nikula.org> <87y26xkqql.fsf@tethera.net> User-Agent: Notmuch/0.33+54~gcaf4513 (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1634131713; a=rsa-sha256; cv=none; b=UVtnzOcNZVCz1NAFEeTGaxCyxaDIHImENgINc+DXPTORsLr9+jnWV0okkfEjAA5V5JwjyS kI5nxinaziDCTBRWrW/tQoXf/aYZtaiTI0xSygqnRj6/pzsLy3HJJEwBeGeTm6nGEL/5YN 5DJv0xj0kC5whpZF0Cb4I1GtErzuckd5FoJgxgTeMp5cRCNdzMIvcded5KhmZiZOulhNCL JtEZ6hxMBnOFh7y1mxi/73e+Kq+K4DNpP2Zs8lwzW/1RdMb1BcyfBG7Coobz+oDaI5713i TSG5Fi7EvBwc24s7hRKE6KRbkJfikv1nr8j7nWQ6XigzoIN4tzw6cl+79yUIGw== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1634131713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=NHX9P+hP8BM/JHT9XQUjzULYdEqVTyzyaOesbWe0xaw=; b=Rf9Bb5fAMwo00KEjgitTQr5GOXqABE5q86dd5Zvo+D/4pmZ4jV7Kz4dgeuFbsiETuP9n3h fcxxfVxMmjayi6+WdhTPr+8ABYBnhioRtZSuLR5Ujjyq3dSAZjceVj9vHUjs/iy6n6MdV5 ugxJht77qAVIretBF0eyScZlaQdU3ip5r5ABMSWHNXvPIHBZ7qTtQjSsTH6GUY+6l4uZfh 8W6uueIgqZrBH/xJX/Zw7Hx4gBpXHKif+EmfggKWkrJIDMreqdsZYb+z7qkO1u8LVP+cFZ gZZIyZMr0uf0E7iwsRMdwry0mhtxVdESL+MUCXb4lybb6AIuSf/rOB8C0WUgLg== Message-ID-Hash: I26FNHZ2HK2LPVYS3XUIAKTINCV4XU34 X-Message-ID-Hash: I26FNHZ2HK2LPVYS3XUIAKTINCV4XU34 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634131723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=UR29oVAeQGj3cOd+H/IkP+OTKC6wbe38X4cbUD1H+Kc=; b=cgVcr5I4DIUVPnRCGXJMCgMTk9xVZ0V+tp2akQF66vBaMLK5JCITCkag9DAFZX27waWpse YfjLbYwC4lnG62qSJmCasDkGLwsU2Kdv6J44OMvReY54ZRYGALLzv/1/q98FKzY7Quwppu OR30PXdBkY5jbQHvskWLuJi7UTPUgRDzGgTPj6kF1elxfyFoJ9aqOUvumaucdCt8X5PbyS J/pN5/GGtUEha/Vs8MPzmspZHvVBdhVnkUl1Xj7c7/QDHu58iBGfFfIj8la/OutmvlXSui TiZ+YHp4qty+IEZQAiJfw1gdHaQNOGdZ7PokHb/0fJeIWiV2sOSc9AVKdEK0jg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1634131723; a=rsa-sha256; cv=fail; b=fpw2DfVmZqN6KeHncJMeXwfZQcVi8FNJM8Y0cqdhm/hhpVlrP5WDLkuynESOptD86C+wLy sr8qp70sh8MnyXXTZS3EOgmdRXQZv3GPU3UpSXjxTQetl3FC/9DoZ4ksNljNCNmrIFos9r iCzRXxKTlo94z2GW8tCg/clfFOBKMPGinxIotZJ1f/OZj3ipuPMMHQKgK4Bcveoc1slWp8 sP8+NoBd72DCeNruBJygHb6oZbh7/SvosjEJQiQusopZ4EuEfj1yiCRpZkfSUfw3LOlJLG UTDGws/GI/iS0xlJrwo8r92YNgFsUX81qxcIulcJQMaM77vbSes0Z6CsKbFCaQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=EhjefM7b; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.83 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=EhjefM7b; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8A58B284A7 X-Spam-Score: 0.83 X-Migadu-Scanner: scn1.migadu.com X-TUID: v5t3o/ul5Ng2 On Wed, Oct 13 2021, David Bremner wrote: > Jani Nikula writes: > >> Given the named enum typedef: >> >> typedef enum _name_t { ... } name_t; >> >> Hawkmoth uses _name_t as the name for documentation. Typedef the >> anonymous enum: >> >> typedef enum { ... } name_t; >> >> instead to use name_t. We don't really need the enum names for >> anything, and not all of the enum typedefs have them anyway. >> --- > I guess that change would be fine independent of the rest? I had the same thought. Tomi