From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cHmECiNsCmLJDQAAgWs5BA (envelope-from ) for ; Mon, 14 Feb 2022 15:50:11 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id oA7lByNsCmJBvgAA9RJhRA (envelope-from ) for ; Mon, 14 Feb 2022 15:50:11 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 799EA2BCC7 for ; Mon, 14 Feb 2022 15:48:47 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 300525F6DD; Mon, 14 Feb 2022 14:48:45 +0000 (UTC) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [185.185.170.37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 9F7365F3FE for ; Mon, 14 Feb 2022 14:48:43 +0000 (UTC) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 731551B0009A; Mon, 14 Feb 2022 16:48:42 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644850122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ompj4mQGPs7+tHcg2c1Ox2S/L0lHr4Dtjo0slh4V1eo=; b=WzqTLZfj3ZkPUIYfHquJhWEguvUcXuiFBkT0jH5PnvdujHuWslydVcOOcLKj09lpLB8rTs BfgAFrX8O4k5O8pwlo8SjlmsPTiwOTD+cUIyT+vVp/W7xQcTH6J3JJFFUUu0rnL+EXZiGZ FIisLqUBhjUkHpQpSlSitUZWBE1806TWtzstU4p0oFBP0SlUBqS2HONyIQNgKFMy35AIS4 leEX0jew26BjE1XYBzXBSvLZYIWR6obgHeSUkQjI4zxbxBmVtf1i4Ka9ygazlAckmRhIn5 IQj93n8z3TgdwiUNs2RyQRcj/Xf7ifqYKIxeJMIYSSeKnohx3bi9FoqR/eECJg== From: Tomi Ollila To: David Bremner , Michael J Gruber Subject: Re: Test suite timing issues? In-Reply-To: <878rudwnrt.fsf@tethera.net> References: <164458773197.3086.16103597141743611268.git@grubix.eu> <87k0e1x87f.fsf@tethera.net> <164467277576.6467.13919733764427871872.git@grubix.eu> <874k54xfuw.fsf@tethera.net> <87v8xjx048.fsf@tethera.net> <878rudwnrt.fsf@tethera.net> User-Agent: Notmuch/0.35+4~ge2bb4cd (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1644850122; a=rsa-sha256; cv=none; b=P6QUinQ82RUGgEjnc4WxbB5nIeS3J9KxHdeIZMXubHmodGILEBKu3hnSIk2HcHnpX+Y218 6h6goOj8HIHjX+gZGHN+FttoVQ2SGdqnH0CYV/82LeHgkZS/6pP/WBasBC9UKgeqpH8HM1 uXNytD5WlqSuG1PM5VA5AsY/J8xzB6RWz+uHV2UJRyaZ6bBWO65VP4OPiwc1006ohxZfqD pOYi5MnIWWhQu7HWgTNjCXK1ormgsUyHyjrNURYyOUT7fSUek47LyimeYdS7qZ/Ds6g7pQ MjF66wlxvtASUYIb45bG0F4QOg8v8oUxqKAevNKov2X/WFY+Y96VwJ7KtoSJHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1644850122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ompj4mQGPs7+tHcg2c1Ox2S/L0lHr4Dtjo0slh4V1eo=; b=hGdj2pQSooRSBYa2Lb7bjYRNsycz46SA5WTXtob3XuzXzmSVwBcYObZXLM8rX8XCFyw/0u IxpZk3Yg3qef8I1jsnnkA5+q04F22nniSeTL35IEt4GldhfSr3EW7ibHh5y8A1h5aMSMgW p8nW6FBm1f6/lG+IBGNblZWB1jIuD1cP/F5YnQovXmVpfyU6l4LB5Gc2dRTm4tFhANiXLQ wNI3kYiBPyEzsGFPkolucVrol4lOJfYmsssWfSfyFWhbwLzU3zXoAsoI5AAIushl7V4LWh WN9q+ixWgfbqKBhbDdUW60ExMyTD9r1AQR6y/qOMxzlyNhB/GFb+GPaG4opAYg== Message-ID-Hash: S3XOCENGH7SEN3KLVCFIZIX6WDVOCZE5 X-Message-ID-Hash: S3XOCENGH7SEN3KLVCFIZIX6WDVOCZE5 X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: notmuch@notmuchmail.org X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644850127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=qAE7pnL2oRsz5Kih91gD6xSiohfPDqZONIdmazg91Ak=; b=R8wLI8HqG+pXdOmygELX06TDrrW1La74KrDaq8yT/Kus24+njtxVh5opWGvlPbsuXZY+qq diZCxMtBf5cz3orvZIxmlQxqvF3sxyxzP091akS+2/OCmafZ1K0z5fmh3vOVJaTulqvU9v PhOlUemV1ChfOg9RagbBJpSez6EmwhR0tchyeKLejI/bTxjyIUCFp467yAir25yatV51Rn 6lhWvLAuHU1lrMzo4wAhHjMkkdNZGF6iiJaZjtP1Kl8u4QfMvGiBWGSDH+XbgjS+9niwyr oKFTGhwY7RJPPRHM4mW0UB8YWVz+0zxGhwtTyX58gcUxbOVlKqV7p8VQYLu2ow== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1644850127; a=rsa-sha256; cv=fail; b=JoCD2SdIisu+O5j1lS0RzA7BXGybRnXiebN2qYgWS9BrKaC4+ljCTy0uzoGyn6Skf/9opw Am+0WgwT3gedEQEqJQH8PTwaxNCap0qpBVK0f2gwrNxRs4g70Mh8Jr6ywYHHzxvbf8gJRS DrlWoudc6AQ6ouAzXtkJc9gPr7hLqPPKthUMqgPgc6656Dvbk3A12JoJV0JzmUuzDPeXT7 /RG/mh9J6XKxC0Bv/Ra02+fuINT607Gc/xbNBiQLGCPlf+043/sm6I+6E6FziLDPYc9pvC /+e3LKAYmYhYCwZqeuwJRK10g/hRW0w5asdpqm5LWx5qz7Fc9katnWODv8nUgQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=WzqTLZfj; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.35 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=WzqTLZfj; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 799EA2BCC7 X-Spam-Score: -0.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: jrRAFRyMZWk2 On Mon, Feb 14 2022, David Bremner wrote: > Tomi Ollila writes: > >> >> Looked notmuch-new.c -- time_t (seconds since epoch) is used as timestamp >> comparisons (which would indicate the subsecond resolution most fs' provide >> is not used)... >> >> ... and if so, I wonder why some of our tests are not failing all the time >> for everyone...? > > Not claiming everything is fine, but there is code there targetted at > the failure mode you mentioned: > > /* If the directory's mtime is the same as the wall-clock time > * when we stat'ed the directory, we skip updating the mtime in > * the database because a message could be delivered later in this > * same second. This may lead to unnecessary re-scans, but it > * avoids overlooking messages. */ > if (fs_mtime != stat_time) > _filename_list_add (state->directory_mtimes, path)->mtime = > fs_mtime; Right. Very much explains why we don't see test failures... > BTW, I have so far run the test suite 68 times in a row without failures > on a Debian s390x host. The file system is ext4, mounted relatime. It > would be interesting to know what file system is yielding the failures > Michael is seeing. indeed. Tomi