[PATCH] lib/Makefile.local: depend on libs we are linking with

[PATCH] lib/Makefile.local: depend on libs we are linking with

[Amadeusz Żołnowski]

---
 lib/Makefile.local | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Makefile.local b/lib/Makefile.local
index 7785944..155ac02 100644
--- a/lib/Makefile.local
+++ b/lib/Makefile.local
@@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
 $(dir)/libnotmuch.a: $(libnotmuch_modules)
 	$(call quiet,AR) rcs $@ $^
 
-$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
+$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
 	$(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
 
 notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
-- 
1.8.1.1

Re: [PATCH] lib/Makefile.local: depend on libs we are linking with

[Jani Nikula]

LGTM, and fixes the issue.

On Mon, 21 Jan 2013, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
> ---
>  lib/Makefile.local | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Makefile.local b/lib/Makefile.local
> index 7785944..155ac02 100644
> --- a/lib/Makefile.local
> +++ b/lib/Makefile.local
> @@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
>  $(dir)/libnotmuch.a: $(libnotmuch_modules)
>  	$(call quiet,AR) rcs $@ $^
>  
> -$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
> +$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
>  	$(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
>  
>  notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
> -- 
> 1.8.1.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] lib/Makefile.local: depend on libs we are linking with

[Tomi Ollila]

On Tue, Jan 22 2013, Jani Nikula <jani@nikula.org> wrote:

> LGTM, and fixes the issue.

LGTM.

Tomi

>
> On Mon, 21 Jan 2013, Amadeusz Żołnowski <aidecoe@aidecoe.name> wrote:
>> ---
>>  lib/Makefile.local | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/Makefile.local b/lib/Makefile.local
>> index 7785944..155ac02 100644
>> --- a/lib/Makefile.local
>> +++ b/lib/Makefile.local
>> @@ -73,7 +73,7 @@ libnotmuch_modules := $(libnotmuch_c_srcs:.c=.o) $(libnotmuch_cxx_srcs:.cc=.o)
>>  $(dir)/libnotmuch.a: $(libnotmuch_modules)
>>  	$(call quiet,AR) rcs $@ $^
>>  
>> -$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym
>> +$(dir)/$(LIBNAME): $(libnotmuch_modules) notmuch.sym util/libutil.a parse-time-string/libparse-time-string.a
>>  	$(call quiet,CXX $(CXXFLAGS)) $(libnotmuch_modules) $(FINAL_LIBNOTMUCH_LDFLAGS) $(LIBRARY_LINK_FLAG) -o $@ util/libutil.a parse-time-string/libparse-time-string.a
>>  
>>  notmuch.sym: $(srcdir)/$(dir)/notmuch.h $(libnotmuch_modules)
>> -- 
>> 1.8.1.1

Re: [PATCH] lib/Makefile.local: depend on libs we are linking with

[David Bremner]

Amadeusz Żołnowski <aidecoe@aidecoe.name> writes:

> ---
>  lib/Makefile.local | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Pushed. Although a slightly more verbose commit message would have been
nice.

d