unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
* [PATCH] emacs: tag: fix compile warning
@ 2013-05-14  8:13 Mark Walters
  2013-05-15 19:47 ` Tomi Ollila
  2013-05-16  2:42 ` David Bremner
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Walters @ 2013-05-14  8:13 UTC (permalink / raw)
  To: notmuch

When compiling notmuch-tag.el there is a compile warning:
notmuch-tag.el:27:1:Warning: cl package required at runtime

Since we have decided to allow runtime use of cl we suppress this
warning by adding a tail comment to the file.
---

This warning has irritated me for some time: thanks to Austin (on irc)
for pointing out how to fix it.

Best wishes

Mark

 emacs/notmuch-tag.el |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
index 75a438b..064cfa8 100644
--- a/emacs/notmuch-tag.el
+++ b/emacs/notmuch-tag.el
@@ -292,3 +292,7 @@ begin with a \"+\" or a \"-\". If REVERSE is non-nil, replace all
 ;;
 
 (provide 'notmuch-tag)
+
+;; Local Variables:
+;; byte-compile-warnings: (not cl-functions)
+;; End:
-- 
1.7.9.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: tag: fix compile warning
  2013-05-14  8:13 [PATCH] emacs: tag: fix compile warning Mark Walters
@ 2013-05-15 19:47 ` Tomi Ollila
  2013-05-16  2:42 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: Tomi Ollila @ 2013-05-15 19:47 UTC (permalink / raw)
  To: Mark Walters, notmuch

On Tue, May 14 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> When compiling notmuch-tag.el there is a compile warning:
> notmuch-tag.el:27:1:Warning: cl package required at runtime
>
> Since we have decided to allow runtime use of cl we suppress this
> warning by adding a tail comment to the file.

> ---

LGTM.

Tomi


>
> This warning has irritated me for some time: thanks to Austin (on irc)
> for pointing out how to fix it.
>
> Best wishes
>
> Mark
>
>  emacs/notmuch-tag.el |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
> index 75a438b..064cfa8 100644
> --- a/emacs/notmuch-tag.el
> +++ b/emacs/notmuch-tag.el
> @@ -292,3 +292,7 @@ begin with a \"+\" or a \"-\". If REVERSE is non-nil, replace all
>  ;;
>  
>  (provide 'notmuch-tag)
> +
> +;; Local Variables:
> +;; byte-compile-warnings: (not cl-functions)
> +;; End:
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] emacs: tag: fix compile warning
  2013-05-14  8:13 [PATCH] emacs: tag: fix compile warning Mark Walters
  2013-05-15 19:47 ` Tomi Ollila
@ 2013-05-16  2:42 ` David Bremner
  1 sibling, 0 replies; 3+ messages in thread
From: David Bremner @ 2013-05-16  2:42 UTC (permalink / raw)
  To: Mark Walters, notmuch

Mark Walters <markwalters1009@gmail.com> writes:

> When compiling notmuch-tag.el there is a compile warning:
> notmuch-tag.el:27:1:Warning: cl package required at runtime
>


pushed the patch.

Someone (TM) should investigate the new cl- prefixed functions,
e.g. cl-loop which maybe me less hassle in the long run.

d

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2013-05-16  2:42 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-14  8:13 [PATCH] emacs: tag: fix compile warning Mark Walters
2013-05-15 19:47 ` Tomi Ollila
2013-05-16  2:42 ` David Bremner

Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).