From: Tomi Ollila <tomi.ollila@iki.fi>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/2] cli: clean up exit status code returned by the cli commands
Date: Sat, 11 Jan 2014 12:22:52 +0200 [thread overview]
Message-ID: <m28uumyg03.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1389389334-24138-1-git-send-email-jani@nikula.org>
On Fri, Jan 10 2014, Jani Nikula <jani@nikula.org> wrote:
> Apart from the status codes for format mismatches, the non-zero exit
> status codes have been arbitrary. Make the cli consistently return
> either EXIT_SUCCESS or EXIT_FAILURE.
> ---
These 2 patches LGTM.
Tomi
> notmuch-compact.c | 6 +++---
> notmuch-config.c | 23 ++++++++++++++---------
> notmuch-count.c | 16 +++++++---------
> notmuch-dump.c | 21 +++++++++------------
> notmuch-insert.c | 25 +++++++++++--------------
> notmuch-new.c | 18 ++++++++----------
> notmuch-reply.c | 20 +++++++++-----------
> notmuch-restore.c | 23 +++++++++--------------
> notmuch-search.c | 18 ++++++++----------
> notmuch-setup.c | 15 +++++++--------
> notmuch-show.c | 18 ++++++++----------
> notmuch-tag.c | 22 +++++++++++-----------
> notmuch.c | 43 ++++++++++++++++++++++++++++---------------
next prev parent reply other threads:[~2014-01-11 10:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-10 21:28 [PATCH 1/2] cli: clean up exit status code returned by the cli commands Jani Nikula
2014-01-10 21:28 ` [PATCH 2/2] cli: close config and do talloc report also on errors Jani Nikula
2014-01-11 10:22 ` Tomi Ollila [this message]
2014-01-18 13:09 ` [PATCH 1/2] cli: clean up exit status code returned by the cli commands Mark Walters
2014-01-19 0:08 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28uumyg03.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).