Emacs Keybindings no longer work after upgrading to 0.17

Emacs Keybindings no longer work after upgrading to 0.17

[Neeum Zawaz]

Hi,

I have this function:


(define-key notmuch-search-mode-map "a"
      (lambda ()
        "Archive message."
        (interactive)
        (notmuch-search-tag "-inbox")
        (notmuch-search-tag "-lowpriority")
        (notmuch-search-tag "-@review")
        (notmuch-search-tag "-@respond")
	))

With the upgrade, if I try pressing "a" in search view, I get:

Wrong type argument: stringp, 43

Yet if I run the commands manually, it works fine.

The full error, BTW, is:

Debugger entered--Lisp error: (wrong-type-argument stringp 45)
  string-match("^[-+]\\S-+$" 45 nil)
  #[(tag-change) "\305\306\307\310\n	#,?\205\311\312!\207" [tag-change start string regexp inhibit-changing-match-data "^[-+]\\S-+$" nil t string-match error "Tag must be of the form `+this_tag' or `-that_tag'"] 4](45)
  mapc(#[(tag-change) "\305\306\307\310\n	#,?\205\311\312!\207" [tag-change start string regexp inhibit-changing-match-data "^[-+]\\S-+$" nil t string-match error "Tag must be of the form `+this_tag' or `-that_tag'"] 4] "-inbox")
  notmuch-tag("(id:20140414235421.43aad8ffb333@www.pentaxforums.com)" "-inbox")
  notmuch-search-tag("-inbox")
  (lambda nil "Archive message." (interactive) (notmuch-search-tag "-inbox") (notmuch-search-tag "-lowpriority") (notmuch-search-tag "-@review") (notmuch-search-tag "-@respond"))()
  call-interactively((lambda nil "Delete message." (interactive) (notmuch-search-tag "-inbox") (notmuch-search-tag "-lowpriority") (notmuch-search-tag "-@review") (notmuch-search-tag "-@respond")) nil nil)

Strangely enough, the following works in show view.

(define-key notmuch-show-mode-map "a"
      (lambda ()
        "Archive message."
        (interactive)
        (notmuch-show-tag-message "-inbox")
        (notmuch-show-tag-message "-lowpriority")
        (notmuch-show-tag-message "-@review")
        (notmuch-show-tag-message "-@respond")
	))

-- 
Dictionaries are for loosers.


                    /\  /\               /\  /
                   /  \/  \ u e e n     /  \/  a w a z
                       >>>>>>mueen@nawaz.org<<<<<<
                                   anl

 

Re: Emacs Keybindings no longer work after upgrading to 0.17

[Tomi Ollila]

On Wed, Apr 16 2014, Neeum Zawaz <mailinglists@nawaz.org> wrote:

> Hi,
>
> I have this function:
>
>
> (define-key notmuch-search-mode-map "a"
>       (lambda ()
>         "Archive message."
>         (interactive)
>         (notmuch-search-tag "-inbox")
>         (notmuch-search-tag "-lowpriority")
>         (notmuch-search-tag "-@review")
>         (notmuch-search-tag "-@respond")
> 	))
>
> With the upgrade, if I try pressing "a" in search view, I get:
>
> Wrong type argument: stringp, 43

Short answer:

(notmuch-search-tag '("-inbox" "-lowpriority" "-@review" "-@respond"))

i.e. notmuch-search-tag takes list argument in these days... :D

yes, it is inconvenient that formats change, but...

Tomi


>
> Yet if I run the commands manually, it works fine.
>
> The full error, BTW, is:
>
> Debugger entered--Lisp error: (wrong-type-argument stringp 45)
>   string-match("^[-+]\\S-+$" 45 nil)
>   #[(tag-change) "\305\306\307\310\n	#,?\205\311\312!\207" [tag-change start string regexp inhibit-changing-match-data "^[-+]\\S-+$" nil t string-match error "Tag must be of the form `+this_tag' or `-that_tag'"] 4](45)
>   mapc(#[(tag-change) "\305\306\307\310\n	#,?\205\311\312!\207" [tag-change start string regexp inhibit-changing-match-data "^[-+]\\S-+$" nil t string-match error "Tag must be of the form `+this_tag' or `-that_tag'"] 4] "-inbox")
>   notmuch-tag("(id:20140414235421.43aad8ffb333@www.pentaxforums.com)" "-inbox")
>   notmuch-search-tag("-inbox")
>   (lambda nil "Archive message." (interactive) (notmuch-search-tag "-inbox") (notmuch-search-tag "-lowpriority") (notmuch-search-tag "-@review") (notmuch-search-tag "-@respond"))()
>   call-interactively((lambda nil "Delete message." (interactive) (notmuch-search-tag "-inbox") (notmuch-search-tag "-lowpriority") (notmuch-search-tag "-@review") (notmuch-search-tag "-@respond")) nil nil)
>
> Strangely enough, the following works in show view.
>
> (define-key notmuch-show-mode-map "a"
>       (lambda ()
>         "Archive message."
>         (interactive)
>         (notmuch-show-tag-message "-inbox")
>         (notmuch-show-tag-message "-lowpriority")
>         (notmuch-show-tag-message "-@review")
>         (notmuch-show-tag-message "-@respond")
> 	))
>
> -- 
> Dictionaries are for loosers.
>
>
>                     /\  /\               /\  /
>                    /  \/  \ u e e n     /  \/  a w a z
>                        >>>>>>mueen@nawaz.org<<<<<<
>                                    anl
>
>  
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch