From: Tomi Ollila <tomi.ollila@iki.fi>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v5 0/7] emacs: Improve the cited message included in replies
Date: Sun, 14 Feb 2016 21:45:45 +0200 [thread overview]
Message-ID: <m28u2nm5xy.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <1455475199-32622-1-git-send-email-markwalters1009@gmail.com>
On Sun, Feb 14 2016, Mark Walters <markwalters1009@gmail.com> wrote:
> This is a slight update and a rebase of this patch set (previous
> version at
> id:1446894276-7814-1-git-send-email-markwalters1009@gmail.com )
>
> The only change from last time (apart from fixing rebasing to master)
> is the rewording of couple of minor comments inline with dme's review
> of the previous version.
>
> Although I am submitting it is primarily dme's series, with minor
> updates from me.
>
> One particular motivation for this series is that it fixes a long
> standing bug we have that replying to a message with an rfc822 part
> completely omits that part. It also fixes the bug whereby we don't
> include application/octet-stream parts which are actually text/plain
> (and thus are displayed in show mode).
>
> This series makes the reply code use the same code as the show code so
> everything works as expected: the reply buffer looks essentially the
> same as the show buffer.
>
> There is one slight difference: the user might want different part
> headers displayed when replying; both because the audience is
> different (a non-notmuch using recipient) and because the buttons
> don't "work" (you can't click on them to show or view a part).
>
> Dme and I disagree on which of these we would like to see so make that
> customisable.
Does *NOT* look bad, works and (relevant) tests pass.
We'd need at least David to verify that Mark got his (David's that is)
patches properly rebased...
Tomi
>
> The key change is patch 3 which switches how reply works. Also note
> that patch 2 is almost all whitespace change as the changes modify the
> indentation.
>
> Best wishes
>
> Mark
>
>
> David Edmondson (6):
> emacs/show: Re-arrange determination if a part header is necessary
> emacs/show: Accommodate the lack of part header buttons
> emacs/mua: Generate improved cited text for replies
> emacs/show: Remove the 'no-buttons option of
> `notmuch-show-insert-bodypart'
> emacs/show: Make the insertion of part headers overridable.
> emacs/mua: Let user specify which parts get a header in citations.
>
> Mark Walters (1):
> test: fix the tests for the new reply code
>
> emacs/notmuch-mua.el | 60 ++++++++++-----------
> emacs/notmuch-show.el | 144 +++++++++++++++++++++++++++++++-------------------
> test/T310-emacs.sh | 32 +++++++++++
> test/test-lib.el | 4 ++
> 4 files changed, 156 insertions(+), 84 deletions(-)
>
> --
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-02-14 19:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 18:39 [PATCH v5 0/7] emacs: Improve the cited message included in replies Mark Walters
2016-02-14 18:39 ` [PATCH v5 1/7] emacs/show: Re-arrange determination if a part header is necessary Mark Walters
2016-02-14 18:39 ` [PATCH v5 2/7] emacs/show: Accommodate the lack of part header buttons Mark Walters
2016-02-14 18:39 ` [PATCH v5 3/7] emacs/mua: Generate improved cited text for replies Mark Walters
2016-02-20 13:15 ` David Bremner
2016-02-14 18:39 ` [PATCH v5 4/7] emacs/show: Remove the 'no-buttons option of `notmuch-show-insert-bodypart' Mark Walters
2016-02-14 18:39 ` [PATCH v5 5/7] emacs/show: Make the insertion of part headers overridable Mark Walters
2016-02-14 18:39 ` [PATCH v5 6/7] emacs/mua: Let user specify which parts get a header in citations Mark Walters
2016-02-14 18:39 ` [PATCH v5 7/7] test: fix the tests for the new reply code Mark Walters
2016-02-14 19:45 ` Tomi Ollila [this message]
2016-02-17 10:51 ` [PATCH v5 0/7] emacs: Improve the cited message included in replies David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28u2nm5xy.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=markwalters1009@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).