[PATCH] emacs: make use of `message-make-from'

[PATCH] emacs: make use of `message-make-from'

[aeuii]

[-- Attachment #1: Type: text/plain, Size: 53 bytes --]

Please put my address in CC when replying.  Thanks!


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-emacs-make-use-of-message-make-from.patch --]
[-- Type: text/x-diff, Size: 1432 bytes --]

From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
From: stefan <aeuii@posteo.de>
Date: Fri, 8 Apr 2016 22:47:06 +0200
Subject: [PATCH] emacs: make use of `message-make-from'

Will respect `mail-from-style'.
---
 emacs/notmuch-mua.el | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
index cfdac0e..935cbd3 100644
--- a/emacs/notmuch-mua.el
+++ b/emacs/notmuch-mua.el
@@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
 	(push (cons 'User-Agent user-agent) other-headers))))
 
   (unless (assq 'From other-headers)
-    (push (cons 'From (concat
-		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
+    (push (cons 'From (message-make-from
+		       (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
 
   (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
 			     (or switch-function (notmuch-mua-get-switch-function)))
@@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
 	    (ido-completing-read (concat "Sender address for " name ": ") addrs
 				 nil nil nil 'notmuch-mua-sender-history
 				 (car addrs))))
-      (concat name " <" address ">"))))
+      (message-make-from name address))))
 
 (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
 (defun notmuch-mua-new-mail (&optional prompt-for-sender)
-- 
2.7.4

Re: [PATCH] emacs: make use of `message-make-from'

[David Bremner]

aeuii@posteo.de writes:

> -    (push (cons 'From (concat
> -		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> +    (push (cons 'From (message-make-from
> +		       (notmuch-user-name) (notmuch-user-primary-email))) other-headers))

Looks OK to me. Any comments from our emacs front end experts?

d

Re: [PATCH] emacs: make use of `message-make-from'

[Tomi Ollila]

On Sat, Apr 09 2016, aeuii@posteo.de wrote:

> Please put my address in CC when replying.  Thanks!
>
> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.

LTGM

Tomi

> ---
>  emacs/notmuch-mua.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index cfdac0e..935cbd3 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
>  	(push (cons 'User-Agent user-agent) other-headers))))
>  
>    (unless (assq 'From other-headers)
> -    (push (cons 'From (concat
> -		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> +    (push (cons 'From (message-make-from
> +		       (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>  
>    (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
>  			     (or switch-function (notmuch-mua-get-switch-function)))
> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
>  	    (ido-completing-read (concat "Sender address for " name ": ") addrs
>  				 nil nil nil 'notmuch-mua-sender-history
>  				 (car addrs))))
> -      (concat name " <" address ">"))))
> +      (message-make-from name address))))
>  
>  (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
>  (defun notmuch-mua-new-mail (&optional prompt-for-sender)
> -- 
> 2.7.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: make use of `message-make-from'

[Mark Walters]

On Sun, 10 Apr 2016, David Edmondson <dme@dme.org> wrote:
> On Fri, Apr 08 2016, aeuii@posteo.de wrote:
>> Please put my address in CC when replying.  Thanks!
>
> Looks good.

I agree.

Best wishes

Mark

>
>> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
>> From: stefan <aeuii@posteo.de>
>> Date: Fri, 8 Apr 2016 22:47:06 +0200
>> Subject: [PATCH] emacs: make use of `message-make-from'
>>
>> Will respect `mail-from-style'.
>> ---
>>  emacs/notmuch-mua.el | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
>> index cfdac0e..935cbd3 100644
>> --- a/emacs/notmuch-mua.el
>> +++ b/emacs/notmuch-mua.el
>> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
>>  	(push (cons 'User-Agent user-agent) other-headers))))
>>  
>>    (unless (assq 'From other-headers)
>> -    (push (cons 'From (concat
>> -		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
>> +    (push (cons 'From (message-make-from
>> +		       (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>>  
>>    (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
>>  			     (or switch-function (notmuch-mua-get-switch-function)))
>> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
>>  	    (ido-completing-read (concat "Sender address for " name ": ") addrs
>>  				 nil nil nil 'notmuch-mua-sender-history
>>  				 (car addrs))))
>> -      (concat name " <" address ">"))))
>> +      (message-make-from name address))))
>>  
>>  (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
>>  (defun notmuch-mua-new-mail (&optional prompt-for-sender)
>> -- 
>> 2.7.4
>>
>> _______________________________________________
>> notmuch mailing list
>> notmuch@notmuchmail.org
>> https://notmuchmail.org/mailman/listinfo/notmuch
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: make use of `message-make-from'

[David Edmondson]

On Fri, Apr 08 2016, aeuii@posteo.de wrote:
> Please put my address in CC when replying.  Thanks!

Looks good.

> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.
> ---
>  emacs/notmuch-mua.el | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/emacs/notmuch-mua.el b/emacs/notmuch-mua.el
> index cfdac0e..935cbd3 100644
> --- a/emacs/notmuch-mua.el
> +++ b/emacs/notmuch-mua.el
> @@ -318,8 +318,8 @@ modified. This function is notmuch addaptation of
>  	(push (cons 'User-Agent user-agent) other-headers))))
>  
>    (unless (assq 'From other-headers)
> -    (push (cons 'From (concat
> -		       (notmuch-user-name) " <" (notmuch-user-primary-email) ">")) other-headers))
> +    (push (cons 'From (message-make-from
> +		       (notmuch-user-name) (notmuch-user-primary-email))) other-headers))
>  
>    (notmuch-mua-pop-to-buffer (message-buffer-name "mail" to)
>  			     (or switch-function (notmuch-mua-get-switch-function)))
> @@ -393,7 +393,7 @@ the From: header is already filled in by notmuch."
>  	    (ido-completing-read (concat "Sender address for " name ": ") addrs
>  				 nil nil nil 'notmuch-mua-sender-history
>  				 (car addrs))))
> -      (concat name " <" address ">"))))
> +      (message-make-from name address))))
>  
>  (put 'notmuch-mua-new-mail 'notmuch-prefix-doc "... and prompt for sender")
>  (defun notmuch-mua-new-mail (&optional prompt-for-sender)
> -- 
> 2.7.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

Re: [PATCH] emacs: make use of `message-make-from'

[David Bremner]

aeuii@posteo.de writes:

> Please put my address in CC when replying.  Thanks!
>
> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
> From: stefan <aeuii@posteo.de>
> Date: Fri, 8 Apr 2016 22:47:06 +0200
> Subject: [PATCH] emacs: make use of `message-make-from'
>
> Will respect `mail-from-style'.

pushed to master, thanks for your contribution to notmuch

d

Re: [PATCH] emacs: make use of `message-make-from'

[aeuii]

2016-04-11 01:57 +0200, David Bremner <david@tethera.net>:

> aeuii@posteo.de writes:
>
>> Please put my address in CC when replying.  Thanks!
>>
>> From 4b9ab261a0ea8a31065e310c5150f522be86d37b Mon Sep 17 00:00:00 2001
>> From: stefan <aeuii@posteo.de>
>> Date: Fri, 8 Apr 2016 22:47:06 +0200
>> Subject: [PATCH] emacs: make use of `message-make-from'
>>
>> Will respect `mail-from-style'.
>
> pushed to master, thanks for your contribution to notmuch
>
> d

Thank you!