Re: [PATCH] test/test-lib.sh: execute basename(1)s lazier in test_expect_equal_file ()

[Tomi Ollila <tomi.ollila@iki.fi>]

On Wed, Oct 26 2016, David Bremner <david@tethera.net> wrote:

> Tomi Ollila <tomi.ollila@iki.fi> writes:
>
>> Moved the 2 basename(1) executions to the test failure branch in
>> test_expect_equal_file ().
>>
>> The output of basename(1) executions in function test_expect_equal_file ()
>> are only used when tests fails -- when all tests pass these 2 basename(1)
>> executions are no longer done at all.
>
> I challenge you to measure the improvement; pushed to master anyway. ;)

if 1 fork(2) takes 1 millisecond, then the full test suite runs 1 second
faster (+ some gain from dropping 500 execve(basename) calls).
So notmuch from execute time viewpoint.
(I actually happen to have suitable LD_PRELOAD library which could ne used
to measure execution times so I might accept the challenge ;D)

but this also reduces noise a bit when debugging test suite problems with 
`set -x` -- for human reader that is an improvement... there would be
somuch more to be improved there but oh well... ;/

Tomi

>
> d