From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id cCMaJbG3jWCVBgEAgWs5BA (envelope-from ) for ; Sat, 01 May 2021 22:18:57 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id eBvEILG3jWCPEAAAB5/wlQ (envelope-from ) for ; Sat, 01 May 2021 20:18:57 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 521F318E41 for ; Sat, 1 May 2021 22:18:57 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 32A0D2716D; Sat, 1 May 2021 16:18:55 -0400 (EDT) Received: from lahtoruutu.iki.fi (lahtoruutu.iki.fi [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id B9BE31FBC5 for ; Sat, 1 May 2021 16:18:52 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id AED2C1B0102D; Sat, 1 May 2021 23:18:51 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GxAVeF6qpZTX7uRrwm+OTWuwCCUYiMwBKaiHJ5FFSkc=; b=Yj/awZE6s/nQ8msHVNx74/3A+J3tE7uIgNOkuOQ6ocHFrIkPHSAZbXyNPA89XzNcOKfgKQ cWPT5H8cTmRpiKNXZzdDIpGogoFd2Am5qcnq6ejd7lTSepwSfJsFXOEeyNxMSomrlhhaIr dhELxQCgHmTJKewoyKgf3LR+7yAvjF+CXus1p+RM+j46TIb82x6UEaHJhc7F/KShIXWCOP 0YRDe5R/yGS1EYujhAa4O9c66K2oS2wSOF6otQVIy1FZmFTZzNOdmRziPj5knO3JPd58OM VbtDqu0It7RpQVhLTfrZfSGmmgmCdKQEKms9ICpBa2d0NyIOY9/tIqJZQzOa+w== From: Tomi Ollila To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 06/13] test: add prereqs check in test_emacs_expect_t In-Reply-To: <20210501115422.483314-7-felipe.contreras@gmail.com> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <20210501115422.483314-7-felipe.contreras@gmail.com> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619900331; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=GxAVeF6qpZTX7uRrwm+OTWuwCCUYiMwBKaiHJ5FFSkc=; b=Lf5wRGL3y2F+jBitmu3JhlbTLpEN7cM4To8MYVtU27SXj2S7afOu7IoaYZr+hvsbRFo21g 8YPRFagOOLuKDfyFdPZ7hlHXiOHrHcSGTbUhZ+WNbccVb/FiB93WmFhf1uM/93Qwqtn/uE 9cAGr7oyueLmx/ItIROpj6N+VZQ3MBJSlIsQUZ2Sqp6uOVjOXvNhPFh1brgFq8EQQpZQDq WyJ1DgiZtvQie+AifwZcNTuB7HyV1WyEH330qu+zC158d6LmJZLwfzVuqSV4atBYSbUakq AykjDc5Tyt5Krk0Aqr6ujQyAeljqVrlzXfVz/kcoKY5CX95yFz8w5lma37iD7g== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619900331; a=rsa-sha256; cv=none; b=NEqlBjGFQd0Yb2BwNcSllbN5t+c7lAFS/zTKuGkmZcheheNx3zXpL+5Fz8BaUUJZCqxSjl G1zEILTUVr7cAaFTQnvHWP6v/nCbCqc145Jbc2MkqFuSw0Y2Vuc1Q7OdkYi4+6y36vgwH4 SaH8FDK2QfrxWxARQzrRlhYD/625kia72llkF8cLekvHAQnCL8x6z/DEiUiiT8RNIVRAVF DD6YwMt3Q63KLXOf2CdnJ1FPaBDg9IUrO6Pao+HO22gjBdow4OW2vcts/s8Rvygdkyw9b5 8RAYo87D+fZQ9Fw17BrZy/cc8Wz5ovxoTFAnkAHuCMSSI2vbOCgiBbEBjgctwQ== Message-ID-Hash: 3KMHPW5SUGU44WATYNNL4PDFHSWZHL2Z X-Message-ID-Hash: 3KMHPW5SUGU44WATYNNL4PDFHSWZHL2Z X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619900337; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=AtjR/3hhDDGHWimuIfSVvCDcqkIdE4V88Xj6gRX3zdc=; b=K8++yzTwto3l6U2lcN1wAOuT87EZOH0dohmHYHggI+PK1mq60eE1FCundlPMesQ5oPyZ1W bRQgq1Hb36LLFbo9f9hXKWM8UdteHsz/FG/Ju3xzkSmnow7QHkltD5SDCcc2G8+ch57AIi vffvUxpiIkpURCpbH8qSWobsP3pqm/JOItTLIQxxKrbrqgTbE8ktsRq3102o20PxEDfqha /LXlRy55XFlyw0CwL4Y/2E0Od+xOBDVI84IHvD/ch1RyaJ4XEfahJcAdMCZoFGC7wxuZKo Xjwd1Kdb2q+Ld0yNPVi+D1lOn2DBNDBgAkQUAWPZ8hwgRk1LvjKH3TcpWQD4bQ== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619900337; a=rsa-sha256; cv=fail; b=ZAPytuUu5PjMixsoAgqDmIW80ZMKa3cVF2HafufAFlANR063u7Dv3Jk/FXGDKDuZWvy7Je raWf5mu3fKZgGM18Iu53xh0KWZCHBvbmFriuWBEJxBYIkO0bJsXq9OkeN3ltC/wo3JaLjq ANlSMlTi0GJ2uH6XuoFpgYU1J7c63UolLk6uM7NYOBB4oboklrvNuRKIRxBlbhsxJneK0d hjcrxivfvNOnOljguxhqJvZ3v37H6nOyeQPa62mwP+MLAPd2mJ5lKKxLPZF/RvHhOlWKzJ mBpHMoLytPsZgtbaMEW8a3mN3rN63V4r7o9dmkD5+55ZbWq5E7wkYeRp4GsmGQ== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b="Yj/awZE6"; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 0.94 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b="Yj/awZE6"; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 521F318E41 X-Spam-Score: 0.94 X-Migadu-Scanner: scn0.migadu.com X-TUID: +GxR8pBqtHOb On Sat, May 01 2021, Felipe Contreras wrote: > test_emacs may update the external prereqs, in which case we want to > skip the test rather than fail. > > Signed-off-by: Felipe Contreras > --- > test/test-lib.sh | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/test/test-lib.sh b/test/test-lib.sh > index 1067316d..72ac2e89 100644 > --- a/test/test-lib.sh > +++ b/test/test-lib.sh > @@ -592,6 +592,9 @@ test_emacs_expect_t () { > exec 1>&6 2>&7 # Restore stdout and stderr > inside_subtest= > > + # test_emacs may update missing external prerequisites > + test_check_missing_external_prereqs_ "$test_subtest_name" && return > + Ditto. LGTM. Tomi > # Report success/failure. > result=$(cat OUTPUT) > if [ "$result" = t ] > -- > 2.31.0