From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id OLPrCugzjmBlOwAAgWs5BA (envelope-from ) for ; Sun, 02 May 2021 07:08:56 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id EJWaBugzjmAQFwAA1q6Kng (envelope-from ) for ; Sun, 02 May 2021 05:08:56 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 8CC611F0CD for ; Sun, 2 May 2021 07:08:55 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id CB57B27184; Sun, 2 May 2021 01:08:50 -0400 (EDT) Received: from lahtoruutu.iki.fi (unknown [IPv6:2a0b:5c81:1c1::37]) by mail.notmuchmail.org (Postfix) with ESMTPS id 7BB1F1FAC2 for ; Sun, 2 May 2021 01:08:48 -0400 (EDT) Received: from guru.guru-group.fi (unknown [IPv6:2a02:2380:1:9:5054:ff:feb7:a4bc]) (using TLSv1.2 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: too) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id A95A11B0108D; Sun, 2 May 2021 08:08:35 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619932115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7gfKT00W6lVAYSoI7y2GLjd9xLGs+ogxg+b8LDYJhVw=; b=i3gy7dlIxkYQruM6lc5E0uO3AFfY/OTu96bWqwIKMjzy7N5u2ieo3M9Xj+6ajD+raxHN/m n0UEgIFRy9h0CLAHUIUx0aBtcvxpqX9Rw2yVByODL6z2ZNt7a9QByZ0ElBK/CE4kR0GDM5 Xm9xd1og/mww9hN1YuqEdp5Gb8U3npprouV4OVaY0QV0TQiGmNEI9NGucvtflHj6ncteKy EHd8Lt18gvOCqTB6/zncoVPGiB4H9bTKhTlDukzAqj6gCWOmid2kMf5ciCVSIDS6oMjkz9 nbNPSxQQ6K22Q4G55T+itXG2Lysdyc3V+HAMO35AvFN+hc6Un9ZwKPbZHgW8EA== From: Tomi Ollila To: David Bremner , Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 00/13] test: several fixes and improvements In-Reply-To: <871raqotu6.fsf@tethera.net> References: <20210501115422.483314-1-felipe.contreras@gmail.com> <871raqotu6.fsf@tethera.net> User-Agent: Notmuch/0.31.4+128~gc67b63a (https://notmuchmail.org) Emacs/27.1 X-Face: HhBM'cA~ MIME-Version: 1.0 ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1619932115; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7gfKT00W6lVAYSoI7y2GLjd9xLGs+ogxg+b8LDYJhVw=; b=LjhnxFfnkGAe788a831NBzDGMDBGUVHsZQzgp8l7H6loA/2K2Bx5ct8dMsA6EEfzjBrg4L FoocUtTqbvITQAoEdErNXGPt57id1QiHN26/7ay3qe2O2aAMohUr6q5AelWFdQFXzGgRHC lXthgFx9LuNlpRHmQL9MeczwMnUcLT4NkoDTpTXR4KCj05CPmKjWyjercMMiEvOmAkcFaw e9PhseVXyE4it2hjKVZ8LAj8RGgntT254Rzym+GdlEN5rhwN3bzPPd0q9Pic7ZOp/ICLf3 8k1mP042we1Y7yO42y+C86S5/yeb/7Zxgd7pI/VkZlTqIn0axMAh641k2n0XcA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=too smtp.mailfrom=tomi.ollila@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1619932115; a=rsa-sha256; cv=none; b=uClWqmfxEjnBbOQcRpGAyat5vNmEw1YFnKFl7ttTCNsGnAQeNz6Hv/FrcBVTAQAKHQ9JiA jv+FGlC8+DSqWWLgXJMwYlbogufDV2L9+5PqInPq8TD/6AYPG5c84eTD/tt631kpuz4azl NVeyoXcOvzN1MWRuJaXc2/dQuA5aXqfcOgafbz/3gszpoJOELxcL6f+8yyCfctzF8wLINS oMRGdeAxGPC/DUVbVjJMTs7PjQpCDRrqw8qOOi2OBXuekzUoR2akIj0wcBVp4XbEGrURiB u7w5aAbkUpcEyr/lmU7GvOmiWF+UNX46YjEJrcyMMh6qJENzHssbeulxa9WueA== Message-ID-Hash: OYNGIFYKGCVEFY4IHOAVOFRZID5XIRVS X-Message-ID-Hash: OYNGIFYKGCVEFY4IHOAVOFRZID5XIRVS X-MailFrom: tomi.ollila@iki.fi X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Daniel Kahn Gillmor X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1619932136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=rwEdNYMim3B6kJai4nAxUdWuVBdrjfqdnrg0G9fJopY=; b=bVmTaZQNRvl3or2ZVQfjGzNT+CrmbzIEnl7Z1yof669nbSJeaY/noZMcsAckk+s7aWay6J Nse4BFyRSO+vy3gn41AFNEQ7z9X/iAstDgWKInu9WkCvdTS8t0mMWlN+6iGGzANHdX9iBE rK5uEC9B89E+6dBAntyeHErXDkB0jeit4p+phVFqYMEGYV17BLLSndkbR0Rjxylql/Tv2B i0SIhEdc/bDgX8Afo3TqL0F3aMDKHmNFwFfevAA05pP+sO6hZz1OBLKl8ea4ewWyUofmKG wMBfFVU2d6Pwkmtc7fyk3uGV5sA02ON221R5TAw/PgBUVuabvAsXB2KJwoVZKg== ARC-Seal: i=2; s=key1; d=yhetil.org; t=1619932136; a=rsa-sha256; cv=fail; b=c1GC074G2TBpEpOCJu7X0yDAMPvKci342b6NF1m1JECkrBvwH093RMSs0WAUQzyD4fc1hQ TmSWpS+q1/C3iWLko5iimnlcTISv0rlAYf8/3ssNWLNQ8MBwAv99VvYtqUGAh1w87UEdte kmUs4Cps7YNYgGNrveWw/7MRHbR64DHw7rSxYzrZu9Nhj/msKk5iuymuNWeWq7zhrHy6po 9Z2mS5nDSm0xYcbxbdNffYMQ+x41+4iFeYC4xh7u0rmHnIXalGZ3U3dgAbhvpDFsRezHWN ZNTy35tT/aJTGd3XFMp8L0pkKnqiCtupUYnVahdWx2CUGCfS43OTYbVFPqacJA== ARC-Authentication-Results: i=2; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=i3gy7dlI; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: 2.41 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=iki.fi header.s=lahtoruutu header.b=i3gy7dlI; arc=reject ("signature check failed: fail, {[1] = sig:iki.fi:reject}"); dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 8CC611F0CD X-Spam-Score: 2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: cu9PCZl6gaGS On Sat, May 01 2021, David Bremner wrote: > Felipe Contreras writes: > >> The current tests fail on my machine due to my configuration, mainly because I didn't have dtach >> installed, but also other stuff. >> >> The following patches fix all the issues I found, and also do plenty of cleanups. > > I have applied 1,2,4,5,6,7 to master. 10, 11, and 12 are also marked > ready to apply, but currently don't because of skipped patches. Good progress ! Now in the morning, after good night's sleep, I think of the following: The following changes could be done (in 2 or 3 (3 for consistency) places): --- a/test/T590-libconfig.sh +++ b/test/T590-libconfig.sh @@ -375,18 +375,19 @@ test_begin_subtest "load default values" export MAILDIR=${MAIL_DIR} cat c_head - c_tail <<'EOF' | test_C ${MAIL_DIR} '' %NULL% { notmuch_config_key_t key; for (key = NOTMUCH_CONFIG_FIRST; key < NOTMUCH_CONFIG_LAST; key = (notmuch_config_key_t)(key + 1)) { const char *val = notmuch_config_get (db, key); printf("%s\n", val ? val : "NULL" ); + printf("%s = %s\n", key, val ? val : "NULL" ); } } EOF Then, update the EXPECTED strings. Finally, move the notmuch_passwd_sanitize () from lib to T590-libconfig.sh (perhaps rename to more "specialized" name) and change it to first match key before replacing the value in the c program output (and replace to empty strings, too!). I am soon going somewhere, I'll look this in the evening in (+0300 timezone) unless someone(tm) is faster there... > > d Tomi