From: David Edmondson <dme@dme.org>
To: Tomi Ollila <tomi.ollila@iki.fi>,
Jonathan Wilner <jonathan@teamwilner.com>,
David Bremner <david@tethera.net>, jao <jao@gnu.org>,
notmuch@notmuchmail.org
Cc: jao <jao@gnu.org>
Subject: Re: [PATCH] emacs: honour notmuch-show-text/html-blocked-images in w3m messages
Date: Thu, 19 Aug 2021 11:16:16 +0100 [thread overview]
Message-ID: <m28s0x7n9r.fsf@dme.org> (raw)
In-Reply-To: <m2bl5t7o9g.fsf@guru.guru-group.fi>
On Thursday, 2021-08-19 at 12:54:51 +03, Tomi Ollila wrote:
> On Tue, Aug 17 2021, David Edmondson wrote:
>
>> On Tuesday, 2021-08-17 at 09:07:53 -07, Jonathan Wilner wrote:
>>
>>> Apologies in advance for thread-jacking this patch !
>>>
>>> No matter what I try to do, I can't configure notmuch/emacs to show
>>> any inline images. That's using any of the renderer options, from shr
>>> to the various w3ms, other than html2text. I've set every possible
>>> variable to allow things, to no avail.
>>>
>>> Using w3m under Emacs on the same machine pulls in local and network images fine.
>>>
>>> Does anyone either have this working as the default or even using a
>>> toggle ("T") to enable images one message at time?
>>
>> I use (with shr):
>>
>> (defun dme:notmuch-show-refresh-show-images ()
>> "Refresh the current buffer with external images enabled."
>> (interactive)
>> (make-local-variable 'notmuch-show-text/html-blocked-images)
>> (setq notmuch-show-text/html-blocked-images nil)
>
> How does let-bind differ with the above ?
It would be fine.
>> (notmuch-show-refresh-view))
>> (define-key notmuch-show-mode-map "I" 'dme:notmuch-show-refresh-show-images)
>>
>
> Tomi
>
>>>
>>> Thanks in advance,
>>>
>>> Jonathan
>>>
>>> David Bremner <david@tethera.net> writes:
>>>
>>>> jao <jao@gnu.org> writes:
>>>>
>>>>> When mm-text-html-renderer is set to 'w3m, the variable playing the
>>>>> role of a regular expression for blocked images is
>>>>> w3m-ignored-image-url-regexp. We bind it when the renderer is not
>>>>> 'shr.
>>>>> ---
>>>> applied to master
>>>> _______________________________________________
>>>> notmuch mailing list -- notmuch@notmuchmail.org
>>>> To unsubscribe send an email to notmuch-leave@notmuchmail.org
>>> _______________________________________________
>>> notmuch mailing list -- notmuch@notmuchmail.org
>>> To unsubscribe send an email to notmuch-leave@notmuchmail.org
>> _______________________________________________
>> notmuch mailing list -- notmuch@notmuchmail.org
>> To unsubscribe send an email to notmuch-leave@notmuchmail.org
> _______________________________________________
> notmuch mailing list -- notmuch@notmuchmail.org
> To unsubscribe send an email to notmuch-leave@notmuchmail.org
prev parent reply other threads:[~2021-08-19 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-04 0:02 [PATCH] emacs: honour notmuch-show-text/html-blocked-images in w3m messages jao
2021-08-04 1:59 ` David Bremner
2021-08-17 16:07 ` Jonathan Wilner
2021-08-17 16:32 ` David Edmondson
2021-08-17 16:39 ` Jonathan Wilner
2021-08-19 9:54 ` Tomi Ollila
2021-08-19 10:16 ` David Edmondson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m28s0x7n9r.fsf@dme.org \
--to=dme@dme.org \
--cc=david@tethera.net \
--cc=jao@gnu.org \
--cc=jonathan@teamwilner.com \
--cc=notmuch@notmuchmail.org \
--cc=tomi.ollila@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).