Re: [PATCH 0/5] Disable search.exclude_tags for 0.12

[Tomi Ollila <tomi.ollila@iki.fi>]

On Wed, 29 Feb 2012 18:13:04 +0000, Mark Walters <markwalters1009@gmail.com> wrote:
> As requested by David (Bremner) on irc here is a patch series
> disabling the search.exclude_tags feature as a temporary measure for
> the 0.12 release.
> 
> There are two options:
> 
> The first is to disable the addition of the new search.exclude_tags
> item to the config file and stop setup from asking for it.
> 
> The second is to do the above and also disable the functionality in
> notmuch-search.c and notmuch-count.c.

I first thought that "full" revert would be best in order to reduce
confusion, but now I'd vote for just disabling the addition but leaving
the feature there.
This way the bleeding edge users who already use this feature could
test the release branch version in daily use. As the feature is there
some brave future 0.12 users can start experimenting with it earlyer
and potentially provide feedback. Finally, as the delta is smaller
there is less management activities to be done.
Marking the feature as 'experimental' in namual page & other documentation
would be good idea.

Tomi

> The idea is that this these are minimal (and thus relatively safe)
> changes to make.  With the first option users who have configured the
> functionality for themselves (while using git) will still get the
> feature: it just won't be pushed on users. With the second option the
> festure will be completely disabled.
> 
> Essentially patch 1 implements the first option and patch 4 the second
> option.  The other patches in the series update the NEWS file, the man
> page and the tests. If going for the first option then I would suggest
> applying (in addition to patch 1) patch 2 (NEWS) and probably patch 3
> (man) although as the functionality remains the latter is not strictly
> necessary. The test patch (patch 5) is not necessary as the tests set
> search.exclude_tags directly.
> 
> If going for the second option then all the patches are needed.
> 
> Finally, please could someone familiar with the config/setup code
> check patch 1 carefully. I have never looked at that code before and
> could easily have done something stupid.
> 
> Best wishes
> 
> Mark
> 
> Mark Walters (5):
>   config: disable addition of exclude tags for 0.12
>   NEWS: revert NEWS item for exclude tags for 0.12
>   man: remove search.exclude_tags from notmuch-config.1 for 0.12
>   cli: temporarily remove exclude tag support for 0.12
>   test: mark exclude tests broken for 0.12
> 
>  NEWS                      |   18 ------------------
>  man/man1/notmuch-config.1 |    8 --------
>  notmuch-config.c          |    3 +--
>  notmuch-count.c           |    8 +-------
>  notmuch-search.c          |    8 +-------
>  notmuch-setup.c           |   19 +------------------
>  test/search               |    2 ++
>  7 files changed, 6 insertions(+), 60 deletions(-)
> 
> -- 
> 1.7.2.3
> 
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
>