From: Tomi Ollila <tomi.ollila@iki.fi>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] test: emacs: run list-processes after accept-process-output in emacs 23.1
Date: Thu, 16 Aug 2012 10:44:05 +0300 [thread overview]
Message-ID: <m27gsz2se2.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20120813151613.GN11179@mit.edu>
On Mon, Aug 13 2012, Austin Clements <amdragon@MIT.EDU> wrote:
> Quoth Tomi Ollila on Aug 05 at 2:13 pm:
>> When running emacs tests using emacs 23.1.1 the tests block (until timeout)
>> when emacs function (notmuch-test-wait) is called.
>>
>> There is an emacs bug #2930 titled:
>> 23.0.92; `accept-process-output' and `sleep-for' do not run sentinel
>>
>> It seems this is present in emacs 23.1.
>>
>> Calling list-processes after accept-process-output seems work around
>> this problem; in case Emacs version is 23.1 a defadvice is activated
>> to do just that.
>
> Should this workaround perhaps go in notmuch-test-wait directly,
> instead of being implemented as advice?
This way the fact that this is workaround for bug that exists only in
23.1(*) is emphasized; The notmuch-test-wait can exist in a (simpler)
format where it doesn't need to know about this bug.
(*) This bug probably exists in emacs 22 but the MUA has not worked
on emacs 22 at least for a year now.
> If we do want to keep it as advice, should it go in notmuch-lib.el
> along with the few other compatibility functions?
In tests we have fixed environment where we can write workarounds
as "global" advices. If we did this in notmuch-lib.el we'd be changing
users' environment, possibly causing surprises...
... but neither sleep-for or accept-process-output are used in
any of the notmuch elisp code so such "fixes" are not needed now...
... and this would ever be a problem, we might already support only
emacs 24 or newer >;) ...
Tomi
>> ---
>>
>> Thanks to Austin for the comments and IRC discussions on the matter.
>>
>> test/test-lib.el | 8 ++++++++
>> 1 files changed, 8 insertions(+), 0 deletions(-)
>>
>> diff --git a/test/test-lib.el b/test/test-lib.el
>> index 52d9936..4330352 100644
>> --- a/test/test-lib.el
>> +++ b/test/test-lib.el
>> @@ -35,6 +35,16 @@
>> "Disable yes-or-no-p before executing kill-emacs"
>> (defun yes-or-no-p (prompt) t)))
>>
>> +;; Emacs bug #2930:
>> +;; 23.0.92; `accept-process-output' and `sleep-for' do not run sentinels
>> +;; seems to be present in Emacs 23.1.
>> +;; Running `list-processes' after `accept-process-output' seems to work
>> +;; around this problem.
>> +(if (and (= emacs-major-version 23) (= emacs-minor-version 1))
>> + (defadvice accept-process-output (after run-list-processes activate)
>> + "run list-processes after executing accept-process-output"
>> + (list-processes)))
>> +
>> (defun notmuch-test-wait ()
>> "Wait for process completion."
>> (while (get-buffer-process (current-buffer))
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2012-08-16 7:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-05 11:13 [PATCH 1/2] test: emacs: call accept-process-output in notmuch-test-wait Tomi Ollila
2012-08-05 11:13 ` [PATCH 2/2] test: emacs: run list-processes after accept-process-output in emacs 23.1 Tomi Ollila
2012-08-13 15:16 ` Austin Clements
2012-08-16 7:44 ` Tomi Ollila [this message]
2012-08-17 18:55 ` Austin Clements
2012-08-05 21:41 ` [PATCH 1/2] test: emacs: call accept-process-output in notmuch-test-wait Jameson Graef Rollins
2012-08-29 22:11 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27gsz2se2.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).