Re: [PATCH v2] emacs: show: change emacs interactive pipe message.

[Tomi Ollila <tomi.ollila@iki.fi>]

On Sun, Jun 09 2013, Mark Walters <markwalters1009@gmail.com> wrote:

> Previously the query string for piping a message to a command was
> "Pipe message to command: " regardless of whether the function was
> called with a prefix argument (which pipes all open messages to the
> command). This patch modifies the `interactive' command to reflect
> this.
> ---
> This has the whitespace fix Tomi mentioned but is otherwise unchanged.

LGTM, my review comments in id:m2wqqftvu3.fsf@guru.guru-group.fi apply.

> Best wishes

Tomi


>
> Mark
>
>
>  emacs/notmuch-show.el |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
>
> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
> index 83bb9ad..d863f2b 100644
> --- a/emacs/notmuch-show.el
> +++ b/emacs/notmuch-show.el
> @@ -1702,7 +1702,10 @@ to stdout or stderr will appear in the *notmuch-pipe* buffer.
>  When invoked with a prefix argument, the command will receive all
>  open messages in the current thread (formatted as an mbox) rather
>  than only the current message."
> -  (interactive "P\nsPipe message to command: ")
> +  (interactive (let ((query-string (if current-prefix-arg
> +				       "Pipe all open messages to command: "
> +				     "Pipe message to command: ")))
> +		 (list current-prefix-arg (read-string query-string))))
>    (let (shell-command)
>      (if entire-thread
>  	(setq shell-command
> -- 
> 1.7.9.1
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch