Re: [PATCH] test suite: don't consider skipped individual tests as failing

[Tomi Ollila <tomi.ollila@iki.fi>]

On Thu, Sep 24 2015, David Bremner <david@tethera.net> wrote:

> It isn't completely clear what we want to do here, but
>
> 1) We currently don't fail if we skip a whole test file (mainly because
> we neglect to count those skipped tests properly). This change at least
> makes the two kinds of skipping consistent.
>
> 2) Automated build environments may have good reasons for building with
> a minimal set of prereqs, and we don't want to discourage running our
> test suite by breaking builds.
> ---
>  test/aggregate-results.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/test/aggregate-results.sh b/test/aggregate-results.sh
> index b016edb..b30da44 100755
> --- a/test/aggregate-results.sh
> +++ b/test/aggregate-results.sh
> @@ -82,7 +82,7 @@ if [ "$skipped" != "0" ]; then
>      echo "$skipped $tests skipped."
>  fi
>  

Looks OK, but I think there should be (some good) comment here informing
any potential viewer that we're not checking $skipped...

> -if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 -a $skipped -eq 0 ]
> +if [ $success -gt 0 -a $fixed -eq 0 -a $failed -eq 0 ]
>  then
>      exit 0
>  else
> -- 
> 2.5.1

Tomi