From: Tomi Ollila <tomi.ollila@iki.fi>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH 1/3] emacs: generate notmuch-pkg.el
Date: Wed, 16 Nov 2016 19:37:15 +0200 [thread overview]
Message-ID: <m27f838gxg.fsf@guru.guru-group.fi> (raw)
In-Reply-To: <20161111114652.29474-2-david@tethera.net>
On Fri, Nov 11 2016, David Bremner <david@tethera.net> wrote:
> This file contains metadata for the built in (as of emacs 24) packaging
> system.
Series LGTM.
Tomi
> ---
> Makefile.local | 3 +++
> emacs/.gitignore | 1 +
> emacs/Makefile.local | 8 +++++++-
> emacs/notmuch-pkg.el.tmpl | 6 ++++++
> 4 files changed, 17 insertions(+), 1 deletion(-)
> create mode 100644 emacs/notmuch-pkg.el.tmpl
>
> diff --git a/Makefile.local b/Makefile.local
> index d1b0585..0a122ab 100644
> --- a/Makefile.local
> +++ b/Makefile.local
> @@ -19,9 +19,12 @@ DATE:=$(shell date +%F)
> endif
>
> VERSION:=$(shell cat ${srcdir}/version)
> +ELPA_VERSION:=$(subst ~,_,$(VERSION))
> ifeq ($(filter release release-message pre-release update-versions,$(MAKECMDGOALS)),)
> ifeq ($(IS_GIT),yes)
> VERSION:=$(shell git --git-dir=${srcdir}/.git describe --abbrev=7 --match '[0-9.]*'|sed -e s/_/~/ -e s/-/+/ -e s/-/~/)
> +# drop the ~g$sha1 part
> +ELPA_VERSION:=$(word 1,$(subst ~, ,$(VERSION)))
> # Write the file 'version.stamp' in case its contents differ from $(VERSION)
> FILE_VERSION:=$(shell test -f version.stamp && read vs < version.stamp || vs=; echo $$vs)
> ifneq ($(FILE_VERSION),$(VERSION))
> diff --git a/emacs/.gitignore b/emacs/.gitignore
> index 9fa1c44..8e15eed 100644
> --- a/emacs/.gitignore
> +++ b/emacs/.gitignore
> @@ -1,3 +1,4 @@
> .eldeps*
> *.elc
> notmuch-version.el
> +notmuch-pkg.el
> diff --git a/emacs/Makefile.local b/emacs/Makefile.local
> index 2d6aedb..e4f7a04 100644
> --- a/emacs/Makefile.local
> +++ b/emacs/Makefile.local
> @@ -27,6 +27,12 @@ $(dir)/notmuch-version.el: $(srcdir)/$(dir)/notmuch-version.el.tmpl
> @sed -e 's/%AG%/Generated file (from $(<F)) -- do not edit!/' \
> -e 's/%VERSION%/"$(VERSION)"/' $< > $@
>
> +$(dir)/notmuch-pkg.el: $(srcdir)/$(dir)/notmuch-pkg.el.tmpl
> + @sed -e 's/%AG%/Generated file (from $(<F)) -- do not edit!/' \
> + -e 's/%VERSION%/"$(ELPA_VERSION)"/' $< > $@
> +
> +all: $(dir)/notmuch-pkg.el
> +install-emacs: $(dir)/notmuch-pkg.el
>
> emacs_images := \
> $(srcdir)/$(dir)/notmuch-logo.png
> @@ -84,4 +90,4 @@ endif
> mkdir -p "$(DESTDIR)$(emacsetcdir)"
> install -m0644 $(emacs_images) "$(DESTDIR)$(emacsetcdir)"
>
> -CLEAN := $(CLEAN) $(emacs_bytecode) $(dir)/notmuch-version.el
> +CLEAN := $(CLEAN) $(emacs_bytecode) $(dir)/notmuch-version.el $(dir)/notmuch-pkg.el
> diff --git a/emacs/notmuch-pkg.el.tmpl b/emacs/notmuch-pkg.el.tmpl
> new file mode 100644
> index 0000000..de97baa
> --- /dev/null
> +++ b/emacs/notmuch-pkg.el.tmpl
> @@ -0,0 +1,6 @@
> +;; %AG%
> +(define-package
> + "notmuch"
> + %VERSION%
> + "Emacs based front-end (MUA) for notmuch"
> + nil)
> --
> 2.10.2
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch
next prev parent reply other threads:[~2016-11-16 17:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 11:46 convert debian packaging to dh-elpa David Bremner
2016-11-11 11:46 ` [PATCH 1/3] emacs: generate notmuch-pkg.el David Bremner
2016-11-16 17:37 ` Tomi Ollila [this message]
2016-11-11 11:46 ` [PATCH 2/3] debian: convert to use dh-elpa David Bremner
2016-11-11 11:46 ` [PATCH 3/3] debian: changelog stanza for 0.23.1-2 David Bremner
2016-11-17 12:29 ` convert debian packaging to dh-elpa David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m27f838gxg.fsf@guru.guru-group.fi \
--to=tomi.ollila@iki.fi \
--cc=david@tethera.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).