From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 5A2BA6DE00AC for ; Fri, 19 May 2017 02:43:16 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0.495 X-Spam-Level: X-Spam-Status: No, score=0.495 tagged_above=-999 required=5 tests=[AWL=-0.157, SPF_NEUTRAL=0.652] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LxAFCq8bxPN1 for ; Fri, 19 May 2017 02:43:07 -0700 (PDT) Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34]) by arlo.cworth.org (Postfix) with ESMTP id 712816DE009B for ; Fri, 19 May 2017 02:42:57 -0700 (PDT) Received: from guru.guru-group.fi (localhost [IPv6:::1]) by guru.guru-group.fi (Postfix) with ESMTP id 28D2C1001EE for ; Fri, 19 May 2017 12:42:12 +0300 (EEST) From: Tomi Ollila To: notmuch@notmuchmail.org Subject: Re: [PATCH v2 03/11] notmuch-search: add filesize based sort order In-Reply-To: <20170518222708.30032-4-adi@adirat.com> References: <20170518222708.30032-1-adi@adirat.com> <20170518222708.30032-4-adi@adirat.com> User-Agent: Notmuch/0.24+52~g1f96813 (https://notmuchmail.org) Emacs/25.1.1 (x86_64-unknown-linux-gnu) X-Face: HhBM'cA~ MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 09:43:16 -0000 On Fri, May 19 2017, Ioan-Adrian Ratiu wrote: > With this it now becomes possible to order the search results by > filesize using the --sort=biggest-first/smallest-first args. Quick drive-by comment (for now): In many places elsewhere we're talking about 'large' files (e.g. LARGEFILE_SOURCE...) so should we use that terminology here too (?) instead of 'big*' Tomi > > Signed-off-by: Ioan-Adrian Ratiu > --- > lib/notmuch.h | 8 ++++++++ > lib/query.cc | 6 ++++++ > notmuch-search.c | 2 ++ > 3 files changed, 16 insertions(+) > > diff --git a/lib/notmuch.h b/lib/notmuch.h > index f90458ce..b7bf3526 100644 > --- a/lib/notmuch.h > +++ b/lib/notmuch.h > @@ -743,6 +743,14 @@ typedef enum { > */ > NOTMUCH_SORT_MESSAGE_ID, > /** > + * Smallest first. > + */ > + NOTMUCH_SORT_SMALLEST_FIRST, > + /** > + * Biggest first > + */ > + NOTMUCH_SORT_BIGGEST_FIRST, > + /** > * Do not sort. > */ > NOTMUCH_SORT_UNSORTED > diff --git a/lib/query.cc b/lib/query.cc > index 9c6ecc8d..72b725e3 100644 > --- a/lib/query.cc > +++ b/lib/query.cc > @@ -330,6 +330,12 @@ _notmuch_query_search_documents (notmuch_query_t *query, > case NOTMUCH_SORT_MESSAGE_ID: > enquire.set_sort_by_value (NOTMUCH_VALUE_MESSAGE_ID, FALSE); > break; > + case NOTMUCH_SORT_SMALLEST_FIRST: > + enquire.set_sort_by_value (NOTMUCH_VALUE_FILESIZE, FALSE); > + break; > + case NOTMUCH_SORT_BIGGEST_FIRST: > + enquire.set_sort_by_value (NOTMUCH_VALUE_FILESIZE, TRUE); > + break; > case NOTMUCH_SORT_UNSORTED: > break; > } > diff --git a/notmuch-search.c b/notmuch-search.c > index 019e14ee..65ecfaab 100644 > --- a/notmuch-search.c > +++ b/notmuch-search.c > @@ -778,6 +778,8 @@ static const notmuch_opt_desc_t common_options[] = { > { NOTMUCH_OPT_KEYWORD, &search_context.sort, "sort", 's', > (notmuch_keyword_t []){ { "oldest-first", NOTMUCH_SORT_OLDEST_FIRST }, > { "newest-first", NOTMUCH_SORT_NEWEST_FIRST }, > + { "smallest-first", NOTMUCH_SORT_SMALLEST_FIRST }, > + { "biggest-first", NOTMUCH_SORT_BIGGEST_FIRST }, > { 0, 0 } } }, > { NOTMUCH_OPT_KEYWORD, &search_context.format_sel, "format", 'f', > (notmuch_keyword_t []){ { "json", NOTMUCH_FORMAT_JSON }, > -- > 2.13.0 > > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > https://notmuchmail.org/mailman/listinfo/notmuch